Bigtable: copy InstanceName to data.models.#3063
Merged
garrettjonesgoogle merged 1 commit intogoogleapis:masterfrom Mar 20, 2018
Merged
Bigtable: copy InstanceName to data.models.#3063garrettjonesgoogle merged 1 commit intogoogleapis:masterfrom
garrettjonesgoogle merged 1 commit intogoogleapis:masterfrom
Conversation
This is a bit ugly: the autogenerate bigtable data api doesn't reference instances, only tables. So the resource name for instances is never generated. Up until this point I've been borrowing resource name from admin, which is really ugly. This PR simply copies the admin InstanceName to data's models package. At some point in the future when GAPIC implements common resource names, this can be cleaned up
googlebot
added
the
cla: yes
Contributor
Author
|
Please merge when ready |
suztomo
pushed a commit
that referenced
this pull request
Mar 9, 2026
chingor13
pushed a commit
that referenced
this pull request
Mar 24, 2026
* chore: try with random channel hint * chore: add option for random channel * chore: actually use random channel option * chore: only lock the specific wrapper * chore: simplify creation and assignment * chore: make more variables final * chore: use separate pool * chore: use a separate mux client * chore: make init blocking * chore: disable pending tx check * chore: add call durations to client lib * chore: add call_durations * chore: use session pool for mux session * chore: use mux database client * chore: make mux client optional * refactor: move multiplexed session handling to separate class * chore: cleanup * feat: add maintainer * chore: add more tests * chore: fix test failures * fix: ChannelUsageTest should keep session in use for longer * test: skip ChannelUsageTest in all cases * chore: keep track of DatabaseDeleted errors * fix: freeze server to prevent flakiness * fix: freeze server to prevent flakiness * test: add retry loop for second query * chore: remove print statements and add emulator handling in test * test: add tests for maintainer * chore: register SessionConsumer for reflection * chore: skip test as it fails on native build Just skip the entire test, as the scenario is already covered by other tests, and spending time on trying to figure out what is happening in this failure is just a waste of time. * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * chore: add random channel hint as option * chore: add single-use channel hint * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * chore: single-use hint * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * chore: use next available channel * chore: keep track of num transactions and channels in use * chore: remove println * chore: remove option for using session pool for mux * feat: add UNIMPLEMENTED handler * chore: cleanup * chore: add TODO for removing the unimplemented handling * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * chore: run formatter * test: fix flaky tests Fixes #3050 Fixes #3081 Fixes #3080 --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a bit ugly: the autogenerate bigtable data api doesn't reference instances, only tables. So the resource name for instances is never generated. Up until this point I've been borrowing resource name from admin, which is really ugly. This PR simply copies the admin InstanceName to data's models package. At some point in the future when GAPIC implements common resource names, this can be cleaned up