add a smoke-test mvn profile#3085
Merged
neozwu merged 2 commits intogoogleapis:masterfrom Mar 28, 2018
Merged
Conversation
googlebot
added
the
cla: yes
pom.xml
Outdated
| </includes> | ||
| <excludes> | ||
| <exclude>**/*IT.java</exclude> | ||
| </excludes> |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
Author
|
@garrettjonesgoogle PTAL |
suztomo
pushed a commit
that referenced
this pull request
Mar 9, 2026
* chore: Create renovate_config_check.yaml Source-Link: googleapis/synthtool@6612ab8 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:a6aa751984f1e905c3ae5a3aac78fc7b68210626ce91487dc7ff4f0a06f010cc Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
chingor13
pushed a commit
that referenced
this pull request
Mar 24, 2026
…ase-please (#3091) fixes #3085 This change should migrate all required tests from "settings" tab to `.github/sync-repo-settings.yaml`. Also setting up release-please branches for lts. Sync-repo-settings.yaml is updated referencing [this guide](https://github.com/googleapis/repo-automation-bots/tree/main/packages/sync-repo-settings), and settings in google-cloud-java [here](https://github.com/googleapis/google-cloud-java/blob/main/.github/sync-repo-settings.yaml). Release-please.yaml is updated referencing [this](https://github.com/googleapis/repo-automation-bots/tree/main/packages/release-please#configuration) and google-cloud-java settings [here](https://github.com/googleapis/google-cloud-java/blob/main/.github/release-please.yml). **Questions to reviewers:** - Is permission rules with "yoshi-" teams still accurate? Do we prefer java specific teams as admin/push? - This update will override configurations in “Settings” for protected branches, I do not have access to this tab. Can you please double check I am not missing anything AND/OR give me access to it?
chingor13
pushed a commit
that referenced
this pull request
Mar 24, 2026
Uses the gson Java version checker, which is more production-hardened than the custom one in the Spanner client. It seems that the Spanner implementation does not get it right on all versions on Windows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a mvn profile to run smoke tests (by invoking "mvn -P smoke-test verify") once a separate change (googleapis/gapic-generator#1898) is used to generate code.