Skip to content

spanner: use joda LocalDate#3246

Closed
pongad wants to merge 3 commits intogoogleapis:masterfrom
pongad:rm-date
Closed

spanner: use joda LocalDate#3246
pongad wants to merge 3 commits intogoogleapis:masterfrom
pongad:rm-date

Conversation

@pongad
Copy link
Contributor

@pongad pongad commented May 8, 2018

This also lets us nuke com.google.cloud.Date and fixes #3157.

@pongad
spanner: use joda LocalDate
6e5ce19 
This also lets us nuke com.google.cloud.Date and fixes #3157.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 8, 2018
garrettjonesgoogle
garrettjonesgoogle reviewed May 8, 2018
View reviewed changes
google-cloud-spanner/src/main/java/com/google/cloud/spanner/AbstractStructReader.java Outdated
import com.google.cloud.Date;
import com.google.cloud.Timestamp;
import java.util.List;
import org.joda.time.LocalDate;

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@pongad
Copy link
Contributor Author

pongad commented May 8, 2018

@garrettjonesgoogle PTAL

@vkedia
Copy link

vkedia commented May 8, 2018

This is a breaking change and will likely break many clients. Why do we need to do this especially since we will eventually want to use java 8 LocalDate here?

@pongad
Copy link
Contributor Author

pongad commented May 8, 2018

@vkedia Hm, I thought that this was something you wanted to do but didn't have time to do it. We can close this if you'd like.

@vkedia
Copy link

vkedia commented May 8, 2018

No we want to move to java 8 LocalDate at some point but not to this.

@vkedia
Copy link

vkedia commented May 8, 2018

cc @snehashah16

@pongad pongad closed this May 11, 2018
@pongad pongad deleted the rm-date branch May 11, 2018 21:20
suztomo pushed a commit that referenced this pull request Mar 9, 2026
@PhongChuong
feat: Add support for inserting Range values (#3246)
ff1ebc6 
* feat: Add support for inserting Range values

* fix: IT assert to use size instead of const
chingor13 pushed a commit that referenced this pull request Mar 24, 2026
@renovate-bot
deps: update dependency net.bytebuddy:byte-buddy to v1.15.3 (#3246)
8dca091 
This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [net.bytebuddy:byte-buddy](https://bytebuddy.net) | `1.15.2` ->
`1.15.3` |
[![age](https://developer.mend.io/api/mc/badges/age/maven/net.bytebuddy:byte-buddy/1.15.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/net.bytebuddy:byte-buddy/1.15.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/net.bytebuddy:byte-buddy/1.15.2/1.15.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/net.bytebuddy:byte-buddy/1.15.2/1.15.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/googleapis/sdk-platform-java).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC45Ny4wIiwidXBkYXRlZEluVmVyIjoiMzguOTcuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
chingor13 pushed a commit that referenced this pull request Mar 24, 2026
@release-please
chore(main): release 2.47.0 (#3261)
25e9c85 
🤖 I have created a release *beep* *boop*
---


<details><summary>2.47.0</summary>

##
[2.47.0](googleapis/sdk-platform-java@v2.46.1...v2.47.0)
(2024-10-04)


### Features

* **gax:** add API key authentication to ClientSettings
([#3137](googleapis/sdk-platform-java#3137))
([c2488fe](googleapis/sdk-platform-java@c2488fe))
* **gax:** append cred-type header for auth metrics
([#3186](googleapis/sdk-platform-java#3186))
([415bfa2](googleapis/sdk-platform-java@415bfa2))


### Bug Fixes

* address incorrect universe domain validation when quota project id is
set
([#3257](googleapis/sdk-platform-java#3257))
([ce9a6c7](googleapis/sdk-platform-java@ce9a6c7)),
closes
[#3256](googleapis/sdk-platform-java#3256)
* Disable automatically retrieving Universe Domain from Metadata Server
([#3272](googleapis/sdk-platform-java#3272))
([f3ce0ae](googleapis/sdk-platform-java@f3ce0ae))


### Dependencies

* update dependency com.fasterxml.jackson:jackson-bom to v2.18.0
([#3248](googleapis/sdk-platform-java#3248))
([7e83e32](googleapis/sdk-platform-java@7e83e32))
* update dependency com.google.errorprone:error_prone_annotations to
v2.33.0
([#3265](googleapis/sdk-platform-java#3265))
([8781cc0](googleapis/sdk-platform-java@8781cc0))
* update dependency com.google.errorprone:error_prone_annotations to
v2.33.0
([#3266](googleapis/sdk-platform-java#3266))
([e8ce93a](googleapis/sdk-platform-java@e8ce93a))
* update dependency com.google.guava:guava to v33.3.1-jre
([#3228](googleapis/sdk-platform-java#3228))
([7e0bdee](googleapis/sdk-platform-java@7e0bdee))
* update dependency net.bytebuddy:byte-buddy to v1.15.3
([#3246](googleapis/sdk-platform-java#3246))
([8dca091](googleapis/sdk-platform-java@8dca091))
* update google api dependencies
([#3242](googleapis/sdk-platform-java#3242))
([1f7dad7](googleapis/sdk-platform-java@1f7dad7))
* update google auth library dependencies to v1.28.0
([#3267](googleapis/sdk-platform-java#3267))
([fd9f5ff](googleapis/sdk-platform-java@fd9f5ff))
* update googleapis/java-cloud-bom digest to 0cd97b7
([#3260](googleapis/sdk-platform-java#3260))
([57ff323](googleapis/sdk-platform-java@57ff323))
* update grpc dependencies to v1.67.1
([#3258](googleapis/sdk-platform-java#3258))
([ae47933](googleapis/sdk-platform-java@ae47933))
* update grpc dependencies to v1.67.1 in dependencies.properties
([#3279](googleapis/sdk-platform-java#3279))
([3c7dadc](googleapis/sdk-platform-java@3c7dadc))
* update junit5 monorepo to v5.11.2
([#3276](googleapis/sdk-platform-java#3276))
([685f46d](googleapis/sdk-platform-java@685f46d))
* update netty dependencies to v4.1.114.final
([#3263](googleapis/sdk-platform-java#3263))
([b7635cb](googleapis/sdk-platform-java@b7635cb))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkedia vkedia Awaiting requested review from vkedia

1 more reviewer

@garrettjonesgoogle garrettjonesgoogle garrettjonesgoogle left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

com.google.cloud.Date has no interop w/ java.util.Date

4 participants

@pongad @vkedia @garrettjonesgoogle @googlebot