Skip to content

test ackDeadline#3394

Closed
dmitry-s wants to merge 1 commit intogoogleapis:masterfrom
dmitry-s:test-ackdeadline
Closed

test ackDeadline#3394
dmitry-s wants to merge 1 commit intogoogleapis:masterfrom
dmitry-s:test-ackdeadline

Conversation

@dmitry-s
Copy link

@dmitry-s dmitry-s commented Jun 19, 2018

This test reproduces an issue with ackDeadline. It publishes 2 messages, then it pools them and nacks one of them. The other one is not being nacked or acked. Then it tries to pull both messages again, in a loop.

The ackDeadline is set to 10 seconds, so I would expect to get both messages after that time. But the message that wasn't nacked or acked never makes it back.

What is interesting, if I enable debugging and put a break point inside the loop, I am able to get both messages.

I verified that ackDeadline works as expected in gcloud cli tool.

@dmitry-s dmitry-s requested a review from pongad as a code owner June 19, 2018 15:17
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 19, 2018
@pongad
Copy link
Contributor

pongad commented Jun 19, 2018

I think this is mostly expected. The client library will automatically extend (modack) the messages that hasn't been acked or nacked. So not getting the message again is more like a sign that automatic deadline extension is working. By default, the client will auto-extend messages for an hour. You can change this with Subscriber.Builder.setMaxAckExtensionPeriod.

@meltsufin
Copy link
Member

meltsufin commented Jun 19, 2018

@pongad What was the reasoning behind introducing such a long default ack extension? It doesn't even seem to be documented anywhere, whereas it radically changes the expectations of the users of how the ack deadline works.

@meltsufin
Copy link
Member

meltsufin commented Jul 19, 2018

@garrettjonesgoogle Friendly ping.

@garrettjonesgoogle
Copy link
Member

garrettjonesgoogle commented Jul 19, 2018

@pongad should take a look at your question first I think

@pongad
Copy link
Contributor

pongad commented Jul 20, 2018 •
edited
Loading

Sorry I missed this earlier. I believe this was recommended by Pubsub team a long time ago. @kir-titievsky do you happen to know? I'll make a PR to document this.

@meltsufin @dmitry-s Could you tell us what kind of problem this is causing you? I believe you're the first people who want to see duplicates.

@kir-titievsky
Copy link

kir-titievsky commented Jul 23, 2018

@pongad sorry, don't remember any more. I'm assuming the idea was to reduce duplicate deliveries.

@meltsufin
Copy link
Member

meltsufin commented Jul 24, 2018

@pongad The main issue with this behavior is the element of surprise to the users who don't expect the ack deadline to be auto-extended for an hour by default. In the least, this needs to be documented.

@csainty csainty mentioned this pull request Sep 1, 2018
Merged
@pongad
Copy link
Contributor

pongad commented Sep 4, 2018

The behavior is now documented. I'll close this for now, but please let us know if there's still confusion.

@pongad pongad closed this Sep 4, 2018
@meltsufin
Copy link
Member

meltsufin commented Sep 4, 2018

@pongad Link(s)?

@pongad
Copy link
Contributor

pongad commented Sep 10, 2018

It should be in the client doc. Search for "ack management".

suztomo pushed a commit that referenced this pull request Mar 9, 2026
@PhongChuong @gcf-owl-bot
docs: add simple query connection read api sample (#3394)
d407baa 
* Basic setup for connection api sample using simple query

* Update sample to use Connection

* Fix import/lint

* Fix import order

* Remove closing result set as it is not implemented

* Remove necessary TODO comment

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
chingor13 pushed a commit that referenced this pull request Mar 24, 2026
@renovate-bot
deps: update google http client dependencies to v1.45.2 (#3394)
24b02f8 
This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[com.google.http-client:google-http-client](https://redirect.github.com/googleapis/google-http-java-client)
| `1.45.0` -> `1.45.2` |
[![age](https://developer.mend.io/api/mc/badges/age/maven/com.google.http-client:google-http-client/1.45.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/com.google.http-client:google-http-client/1.45.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/com.google.http-client:google-http-client/1.45.0/1.45.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/com.google.http-client:google-http-client/1.45.0/1.45.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
|
[com.google.http-client:google-http-client-gson](https://redirect.github.com/googleapis/google-http-java-client)
| `1.45.0` -> `1.45.2` |
[![age](https://developer.mend.io/api/mc/badges/age/maven/com.google.http-client:google-http-client-gson/1.45.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/com.google.http-client:google-http-client-gson/1.45.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/com.google.http-client:google-http-client-gson/1.45.0/1.45.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/com.google.http-client:google-http-client-gson/1.45.0/1.45.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
|
[com.google.http-client:google-http-client-bom](https://redirect.github.com/googleapis/google-http-java-client/tree/master/google-http-client-bom)
([source](https://redirect.github.com/googleapis/google-http-java-client))
| `1.45.0` -> `1.45.2` |
[![age](https://developer.mend.io/api/mc/badges/age/maven/com.google.http-client:google-http-client-bom/1.45.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/com.google.http-client:google-http-client-bom/1.45.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/com.google.http-client:google-http-client-bom/1.45.0/1.45.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/com.google.http-client:google-http-client-bom/1.45.0/1.45.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>googleapis/google-http-java-client
(com.google.http-client:google-http-client)</summary>

###
[`v1.45.2`](https://redirect.github.com/googleapis/google-http-java-client/blob/HEAD/CHANGELOG.md#1452-2024-12-05)

[Compare
Source](https://redirect.github.com/googleapis/google-http-java-client/compare/v1.45.1...v1.45.2)

##### Bug Fixes

- NPE if response entity is null
([#&#8203;2043](https://redirect.github.com/googleapis/google-http-java-client/issues/2043))
([12c742b](https://redirect.github.com/googleapis/google-http-java-client/commit/12c742b1f7536fd1fd408a74071007b15480b149))

##### Dependencies

- Update actions/checkout action to v4.2.2
([#&#8203;2034](https://redirect.github.com/googleapis/google-http-java-client/issues/2034))
([024fd71](https://redirect.github.com/googleapis/google-http-java-client/commit/024fd718793d20f9439d538b9c342daeb84b89bc))
- Update actions/upload-artifact action to v4.4.3
([#&#8203;2035](https://redirect.github.com/googleapis/google-http-java-client/issues/2035))
([443157c](https://redirect.github.com/googleapis/google-http-java-client/commit/443157c5ff20fdddaf40193e005f43b7bc6a6f54))
- Update dependency com.fasterxml.jackson.core:jackson-core to v2.18.2
([#&#8203;2036](https://redirect.github.com/googleapis/google-http-java-client/issues/2036))
([5d24785](https://redirect.github.com/googleapis/google-http-java-client/commit/5d247854d65075c9e0f8e9076c210f0e93742c46))
- Update dependency com.google.errorprone:error_prone_annotations to
v2.36.0
([#&#8203;2037](https://redirect.github.com/googleapis/google-http-java-client/issues/2037))
([cc6eb61](https://redirect.github.com/googleapis/google-http-java-client/commit/cc6eb61a9f7ae550951ee7b5c8a383d755e76959))
- Update dependency io.grpc:grpc-context to v1.68.2
([#&#8203;2038](https://redirect.github.com/googleapis/google-http-java-client/issues/2038))
([9fba799](https://redirect.github.com/googleapis/google-http-java-client/commit/9fba799ac04c7870f3ee5c425ccb0a51dc7e0d16))
- Update dependency ubuntu to v24
([#&#8203;2041](https://redirect.github.com/googleapis/google-http-java-client/issues/2041))
([ac83eb2](https://redirect.github.com/googleapis/google-http-java-client/commit/ac83eb259331de683806787c172514592d27de01))
- Update github/codeql-action action to v3.27.6
([#&#8203;2003](https://redirect.github.com/googleapis/google-http-java-client/issues/2003))
([dc8e46a](https://redirect.github.com/googleapis/google-http-java-client/commit/dc8e46a6b6308985380e312fad82b7c182dd9e6f))
- Update project.appengine.version to v2.0.31
([#&#8203;2027](https://redirect.github.com/googleapis/google-http-java-client/issues/2027))
([8bb79e5](https://redirect.github.com/googleapis/google-http-java-client/commit/8bb79e5448e0fa2767b029e7101e3d5d5112eaf2))

###
[`v1.45.1`](https://redirect.github.com/googleapis/google-http-java-client/blob/HEAD/CHANGELOG.md#1451-2024-11-12)

[Compare
Source](https://redirect.github.com/googleapis/google-http-java-client/compare/v1.45.0...v1.45.1)

##### Bug Fixes

- Add google-http-client-apache-v5 to bom
([#&#8203;2021](https://redirect.github.com/googleapis/google-http-java-client/issues/2021))
([4830ad7](https://redirect.github.com/googleapis/google-http-java-client/commit/4830ad788a62fe9cd4f64873b771e6ef8ef92193))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/googleapis/sdk-platform-java).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xOS4wIiwidXBkYXRlZEluVmVyIjoiMzkuNDIuNCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
chingor13 pushed a commit that referenced this pull request Mar 24, 2026
@release-please
chore(main): release 2.51.0 (#3382)
5b203a2 
🤖 I have created a release *beep* *boop*
---


<details><summary>2.51.0</summary>

##
[2.51.0](googleapis/sdk-platform-java@v2.50.0...v2.51.0)
(2024-12-12)


### Features

* [iam] add ResourcePolicyMember to google/iam/v1
([eddf289](googleapis/sdk-platform-java@eddf289))


### Bug Fixes

* [#3381](googleapis/sdk-platform-java#3381)
([c475746](googleapis/sdk-platform-java@c475746))
* graalvm missing build time class when using protobuf 4.x
([#3438](googleapis/sdk-platform-java#3438))
([e61cbdd](googleapis/sdk-platform-java@e61cbdd))
* return all library names if repo-level parameter changes
([#3379](googleapis/sdk-platform-java#3379))
([c475746](googleapis/sdk-platform-java@c475746)),
closes
[#3381](googleapis/sdk-platform-java#3381)


### Dependencies

* update dependency com.fasterxml.jackson:jackson-bom to v2.18.2
([#3422](googleapis/sdk-platform-java#3422))
([eeba322](googleapis/sdk-platform-java@eeba322))
* update dependency com.google.api-client:google-api-client-bom to
v2.7.1
([#3450](googleapis/sdk-platform-java#3450))
([dde7a52](googleapis/sdk-platform-java@dde7a52))
* update dependency com.google.auth:google-auth-library-oauth2-http to
v1.30.0
([#3428](googleapis/sdk-platform-java#3428))
([d9eb2df](googleapis/sdk-platform-java@d9eb2df))
* update dependency com.google.errorprone:error_prone_annotations to
v2.36.0
([#3425](googleapis/sdk-platform-java#3425))
([076f7c6](googleapis/sdk-platform-java@076f7c6))
* update dependency com.google.errorprone:error_prone_annotations to
v2.36.0
([#3426](googleapis/sdk-platform-java#3426))
([dd73c63](googleapis/sdk-platform-java@dd73c63))
* update dependency dev.cel:cel to v0.8.0
([#3429](googleapis/sdk-platform-java#3429))
([9b76231](googleapis/sdk-platform-java@9b76231))
* update dependency io.github.java-diff-utils:java-diff-utils to v4.15
([#3430](googleapis/sdk-platform-java#3430))
([09455e9](googleapis/sdk-platform-java@09455e9))
* update dependency net.bytebuddy:byte-buddy to v1.15.10
([#3298](googleapis/sdk-platform-java#3298))
([7cc4ce9](googleapis/sdk-platform-java@7cc4ce9))
* update dependency org.checkerframework:checker-qual to v3.48.3
([#3278](googleapis/sdk-platform-java#3278))
([a27eeea](googleapis/sdk-platform-java@a27eeea))
* update dependency org.easymock:easymock to v5.5.0
([#3431](googleapis/sdk-platform-java#3431))
([a7b6f3d](googleapis/sdk-platform-java@a7b6f3d))
* update dependency packaging to v24.2
([#3432](googleapis/sdk-platform-java#3432))
([bae5f48](googleapis/sdk-platform-java@bae5f48))
* update docker.io/library/alpine docker tag to v3.21.0
([#3433](googleapis/sdk-platform-java#3433))
([7c40ec8](googleapis/sdk-platform-java@7c40ec8))
* update docker.io/library/alpine:3.20.3 docker digest to 1e42bbe
([#3417](googleapis/sdk-platform-java#3417))
([a7c8087](googleapis/sdk-platform-java@a7c8087))
* update docker.io/library/maven:3.9.9-eclipse-temurin-11-alpine docker
digest to 3bab9f2
([#3447](googleapis/sdk-platform-java#3447))
([fde8517](googleapis/sdk-platform-java@fde8517))
* update docker.io/library/maven:3.9.9-eclipse-temurin-11-alpine docker
digest to cdfb386
([#3418](googleapis/sdk-platform-java#3418))
([2dd5eb3](googleapis/sdk-platform-java@2dd5eb3))
* update docker.io/library/python docker tag to v3.13.1
([#3434](googleapis/sdk-platform-java#3434))
([42d4be5](googleapis/sdk-platform-java@42d4be5))
* update google api dependencies
([#3435](googleapis/sdk-platform-java#3435))
([b1cb490](googleapis/sdk-platform-java@b1cb490))
* update google auth library dependencies to v1.30.1
([#3453](googleapis/sdk-platform-java#3453))
([f360c6e](googleapis/sdk-platform-java@f360c6e))
* update google http client dependencies to v1.45.2
([#3394](googleapis/sdk-platform-java#3394))
([24b02f8](googleapis/sdk-platform-java@24b02f8))
* update google http client dependencies to v1.45.3
([#3454](googleapis/sdk-platform-java#3454))
([cdeb7b4](googleapis/sdk-platform-java@cdeb7b4))
* update google.cloud.opentelemetry.version to v0.33.0
([#3436](googleapis/sdk-platform-java#3436))
([6a868b8](googleapis/sdk-platform-java@6a868b8))
* update googleapis/java-cloud-bom digest to 93740d5
([#3280](googleapis/sdk-platform-java#3280))
([16abf70](googleapis/sdk-platform-java@16abf70))
* update grpc dependencies to v1.68.2
([#3420](googleapis/sdk-platform-java#3420))
([950da1d](googleapis/sdk-platform-java@950da1d))
* update grpc dependencies to v1.69.0
([#3451](googleapis/sdk-platform-java#3451))
([cca57bf](googleapis/sdk-platform-java@cca57bf))
* update junit5 monorepo to v5.11.3
([#3310](googleapis/sdk-platform-java#3310))
([1b1abe2](googleapis/sdk-platform-java@1b1abe2))
* update netty dependencies
([#3423](googleapis/sdk-platform-java#3423))
([890ae68](googleapis/sdk-platform-java@890ae68))
* update opentelemetry-java monorepo to v1.44.1
([#3437](googleapis/sdk-platform-java#3437))
([124e82a](googleapis/sdk-platform-java@124e82a))
* update opentelemetry-java monorepo to v1.45.0
([#3439](googleapis/sdk-platform-java#3439))
([0733221](googleapis/sdk-platform-java@0733221))
* update repo-automation-bots digest to 6662ddc
([#3421](googleapis/sdk-platform-java#3421))
([d68b19b](googleapis/sdk-platform-java@d68b19b))
* update repo-automation-bots digest to 8230b4e
([#3448](googleapis/sdk-platform-java#3448))
([d508cde](googleapis/sdk-platform-java@d508cde))
* update repo-automation-bots digest to ae0a72f
([#3452](googleapis/sdk-platform-java#3452))
([49dfb3d](googleapis/sdk-platform-java@49dfb3d))
* update repo-automation-bots digest to f3fbbab
([#3419](googleapis/sdk-platform-java#3419))
([24faa33](googleapis/sdk-platform-java@24faa33))


### Documentation

* explain default generation config in `README.md`
([#3388](googleapis/sdk-platform-java#3388))
([73900d0](googleapis/sdk-platform-java@73900d0))
* hermetic build README syntax fix
([#3391](googleapis/sdk-platform-java#3391))
([ae262b6](googleapis/sdk-platform-java@ae262b6))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
chingor13 pushed a commit that referenced this pull request Mar 24, 2026
@cloud-java-bot
chore: Update generation configuration at Fri Oct 11 02:24:16 UTC 2024 (
2bd9ee2 
#3394)

* chore: Update generation configuration at Fri Oct 11 02:24:16 UTC 2024

* chore: generate libraries at Fri Oct 11 02:24:47 UTC 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pongad pongad Awaiting requested review from pongad

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@dmitry-s @pongad @meltsufin @garrettjonesgoogle @kir-titievsky @googlebot