(WIP) Spanner: Block nested transactions by nithinsujir · Pull Request #3597 · googleapis/google-cloud-java

nithinsujir · 2018-08-22T22:47:16Z

Cloud spanner does not support nested transactions. Use a thread-local
flag to check and throw exception.

Cloud spanner does not support nested transactions. Use a thread-local flag to check and throw exception.

...e-cloud-clients/google-cloud-spanner/src/main/java/com/google/cloud/spanner/SpannerImpl.java

  @VisibleForTesting
  static class TransactionRunnerImpl implements SessionTransaction, TransactionRunner {

+    private static final ThreadLocal<Boolean> inTransaction = new ThreadLocal<Boolean>() {


...e-cloud-clients/google-cloud-spanner/src/main/java/com/google/cloud/spanner/SpannerImpl.java

    @Nullable
    @Override
    public <T> T run(TransactionCallable<T> callable) {
+      if (inTransaction.get() == Boolean.TRUE) {


This takes care of read, write and batch nested transactions.

nithinsujir · 2018-08-31T16:02:27Z

Because I did a push -f earlier, circleci cannot build this branch anymore. Will close and create new PR.

This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.graalvm.sdk:nativeimage](https://redirect.github.com/oracle/graal) | `24.0.1` -> `24.1.2` | [![age](https://developer.mend.io/api/mc/badges/age/maven/org.graalvm.sdk:nativeimage/24.1.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/org.graalvm.sdk:nativeimage/24.1.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/org.graalvm.sdk:nativeimage/24.0.1/24.1.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/org.graalvm.sdk:nativeimage/24.0.1/24.1.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/googleapis/sdk-platform-java).

🤖 I have created a release *beep* *boop* --- <details><summary>2.53.0</summary> ## [2.53.0](googleapis/sdk-platform-java@v2.52.0...v2.53.0) (2025-02-10) ### Features * enable DirectPath bound token in InstantiatingGrpcChannelProvider ([#3572](googleapis/sdk-platform-java#3572)) ([28909c7](googleapis/sdk-platform-java@28909c7)) * Enable MTLS_S2A bound token by default for gRPC S2A enabled flows ([#3591](googleapis/sdk-platform-java#3591)) ([6866c91](googleapis/sdk-platform-java@6866c91)) * migrate away from deprecated graal-sdk dependency to use nativeimage ([#2706](googleapis/sdk-platform-java#2706)) ([5d412b8](googleapis/sdk-platform-java@5d412b8)) ### Bug Fixes * Avoid creating message string prematurely for streaming calls ([#3622](googleapis/sdk-platform-java#3622)) ([f20dbb0](googleapis/sdk-platform-java@f20dbb0)) ### Dependencies * update dependency com.google.code.gson:gson to v2.12.0 ([#3595](googleapis/sdk-platform-java#3595)) ([6d7f949](googleapis/sdk-platform-java@6d7f949)) * update dependency com.google.code.gson:gson to v2.12.0 ([#3596](googleapis/sdk-platform-java#3596)) ([e3df36b](googleapis/sdk-platform-java@e3df36b)) * update dependency com.google.code.gson:gson to v2.12.1 ([#3599](googleapis/sdk-platform-java#3599)) ([1317e73](googleapis/sdk-platform-java@1317e73)) * update dependency com.google.code.gson:gson to v2.12.1 ([#3600](googleapis/sdk-platform-java#3600)) ([fbe371b](googleapis/sdk-platform-java@fbe371b)) * update dependency commons-codec:commons-codec to v1.18.0 ([#3590](googleapis/sdk-platform-java#3590)) ([5459028](googleapis/sdk-platform-java@5459028)) * update dependency io.netty:netty-tcnative-boringssl-static to v2.0.70.final ([#3623](googleapis/sdk-platform-java#3623)) ([9c28cbc](googleapis/sdk-platform-java@9c28cbc)) * update dependency lxml to v5.3.1 ([#3624](googleapis/sdk-platform-java#3624)) ([eb59b20](googleapis/sdk-platform-java@eb59b20)) * update dependency net.bytebuddy:byte-buddy to v1.17.0 ([#3582](googleapis/sdk-platform-java#3582)) ([1e907fc](googleapis/sdk-platform-java@1e907fc)) * update dependency org.checkerframework:checker-qual to v3.49.0 ([#3604](googleapis/sdk-platform-java#3604)) ([2ea2c73](googleapis/sdk-platform-java@2ea2c73)) * update dependency org.graalvm.sdk:nativeimage to v24.1.2 ([#3597](googleapis/sdk-platform-java#3597)) ([5e18c47](googleapis/sdk-platform-java@5e18c47)) * update docker.io/library/maven:3.9.9-eclipse-temurin-11-alpine docker digest to 456f60c ([#3607](googleapis/sdk-platform-java#3607)) ([fd1c4de](googleapis/sdk-platform-java@fd1c4de)) * update docker.io/library/maven:3.9.9-eclipse-temurin-11-alpine docker digest to d323c2b ([#3601](googleapis/sdk-platform-java#3601)) ([5a2b9c6](googleapis/sdk-platform-java@5a2b9c6)) * update docker.io/library/python docker tag to v3.13.2 ([#3615](googleapis/sdk-platform-java#3615)) ([0ec57f8](googleapis/sdk-platform-java@0ec57f8)) * update docker.io/library/python:3.13.1-alpine3.20 docker digest to 7788ec8 ([#3586](googleapis/sdk-platform-java#3586)) ([9f050c3](googleapis/sdk-platform-java@9f050c3)) * update google api dependencies ([#3584](googleapis/sdk-platform-java#3584)) ([5036453](googleapis/sdk-platform-java@5036453)) * update google auth library dependencies to v1.32.0 ([#3611](googleapis/sdk-platform-java#3611)) ([303f424](googleapis/sdk-platform-java@303f424)) * update google auth library dependencies to v1.32.1 ([#3618](googleapis/sdk-platform-java#3618)) ([6b22d71](googleapis/sdk-platform-java@6b22d71)) * update google http client dependencies to v1.46.1 ([#3616](googleapis/sdk-platform-java#3616)) ([f00e32d](googleapis/sdk-platform-java@f00e32d)) * update googleapis/java-cloud-bom digest to 47ad868 ([#3608](googleapis/sdk-platform-java#3608)) ([24956c3](googleapis/sdk-platform-java@24956c3)) * update googleapis/java-cloud-bom digest to 514a644 ([#3602](googleapis/sdk-platform-java#3602)) ([f76b07e](googleapis/sdk-platform-java@f76b07e)) * update googleapis/java-cloud-bom digest to 7752ecd ([#3603](googleapis/sdk-platform-java#3603)) ([9148ad1](googleapis/sdk-platform-java@9148ad1)) * update netty dependencies to v4.1.117.final ([#3581](googleapis/sdk-platform-java#3581)) ([2f60691](googleapis/sdk-platform-java@2f60691)) * update netty dependencies to v4.1.118.final ([#3625](googleapis/sdk-platform-java#3625)) ([bb19557](googleapis/sdk-platform-java@bb19557)) * update netty dependencies to v4.1.118.final ([#3626](googleapis/sdk-platform-java#3626)) ([2752e84](googleapis/sdk-platform-java@2752e84)) * Update OpenTelemetry semantic convention packages in the shared dependencies ([#3402](googleapis/sdk-platform-java#3402)) ([47244b9](googleapis/sdk-platform-java@47244b9)) * update opentelemetry-java monorepo to v1.46.0 ([#3585](googleapis/sdk-platform-java#3585)) ([03dbd8e](googleapis/sdk-platform-java@03dbd8e)) * update opentelemetry-java monorepo to v1.47.0 ([#3619](googleapis/sdk-platform-java#3619)) ([34629d3](googleapis/sdk-platform-java@34629d3)) * update repo-automation-bots digest to 35eff2c ([#3609](googleapis/sdk-platform-java#3609)) ([6ec3b6e](googleapis/sdk-platform-java@6ec3b6e)) * update repo-automation-bots digest to 3a68a9c ([#3620](googleapis/sdk-platform-java#3620)) ([c50bc88](googleapis/sdk-platform-java@c50bc88)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* chore(main): release 6.85.0 * chore: generate libraries at Fri Jan 10 10:30:23 UTC 2025 --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: cloud-java-bot <cloud-java-bot@google.com>

nithinsujir requested a review from pongad as a code owner August 22, 2018 22:47

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 22, 2018

nithinsujir requested a review from snehashah16 August 22, 2018 23:03

nithinsujir changed the title ~~(WIP) Spanner: Block nested transactions~~ Spanner: Block nested transactions Aug 23, 2018

nithinsujir changed the title ~~Spanner: Block nested transactions~~ (WIP) Spanner: Block nested transactions Aug 24, 2018

nithinsujir changed the title ~~(WIP) Spanner: Block nested transactions~~ Spanner: Block nested transactions Aug 24, 2018

Spanner: Block nested transactions

7f00d73

Cloud spanner does not support nested transactions. Use a thread-local flag to check and throw exception.

snehashah16 reviewed Aug 27, 2018

View reviewed changes

Rename inTransaction to hasPendingTransaction

6c3919b

nithinsujir changed the title ~~Spanner: Block nested transactions~~ (WIP) Spanner: Block nested transactions Aug 28, 2018

Move hasPendingTransaction check into initTransaction() and setActive()

a556830

This takes care of read, write and batch nested transactions.

nithinsujir closed this Aug 31, 2018

suztomo pushed a commit that referenced this pull request Mar 9, 2026

deps: update github/codeql-action action to v2.27.6 (#3597)

bc1f3b9

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

(WIP) Spanner: Block nested transactions#3597

(WIP) Spanner: Block nested transactions#3597
nithinsujir wants to merge 3 commits intogoogleapis:masterfrom
nithinsujir:block-nested

nithinsujir commented Aug 22, 2018

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

nithinsujir commented Aug 31, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

nithinsujir commented Aug 22, 2018

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

nithinsujir commented Aug 31, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants