Closed
Conversation
googlebot
added
the
cla: yes
pongad
approved these changes
Sep 6, 2018
Contributor
|
Closing this as we've moved to Kokoro |
suztomo
pushed a commit
that referenced
this pull request
Mar 9, 2026
…to v2-rev20250112-2.0.0 (#3651)
chingor13
pushed a commit
that referenced
this pull request
Mar 24, 2026
…3651) @rockspore pointed out that the credential should be created from scratch because when using [toBuilder](https://github.com/googleapis/google-auth-library-java/blob/main/oauth2_http/java/com/google/auth/oauth2/ComputeEngineCredentials.java#L648) the underlying [access token is copied](https://github.com/googleapis/google-auth-library-java/blob/37d228410e99799e4a7be8650fe472ea712c9b4d/oauth2_http/java/com/google/auth/oauth2/OAuth2Credentials.java#L657). This was confirmed to be a bug with local testing which: - deployed a GAE app, the app performs the below two actions sequentially - create Google API client ( `allowedHardBoundAccessTokens` empty in GrpcProvider) and then ping the API, logs show the bearer token is used, obtained from making call to MDS - create a Google API client ( `allowedHardBoundAccessTokens` contains `MTLS_S2A` in GrpcProvider) and then ping the API, logs show the bearer token is used. A call to MDS is **not** made. This is likely because the credential and channel have different lifetimes.
chingor13
pushed a commit
that referenced
this pull request
Mar 24, 2026
🤖 I have created a release *beep* *boop* --- <details><summary>2.54.0</summary> ## [2.54.0](googleapis/sdk-platform-java@v2.53.0...v2.54.0) (2025-02-25) ### Features * add client side logging with slf4j ([#3403](googleapis/sdk-platform-java#3403)) ([da8ed28](googleapis/sdk-platform-java@da8ed28)) ### Bug Fixes * S2A gRPC flow creates ComputeEngineCredentials via newBuilder. ([#3651](googleapis/sdk-platform-java#3651)) ([e97b8bd](googleapis/sdk-platform-java@e97b8bd)) ### Dependencies * update dependency ch.qos.logback:logback-core to v1.3.15 [security] ([#3654](googleapis/sdk-platform-java#3654)) ([79a248e](googleapis/sdk-platform-java@79a248e)) * update google api dependencies ([#3631](googleapis/sdk-platform-java#3631)) ([f0d09aa](googleapis/sdk-platform-java@f0d09aa)) * update google auth library dependencies to v1.33.1 ([#3656](googleapis/sdk-platform-java#3656)) ([f48ee03](googleapis/sdk-platform-java@f48ee03)) * update google http client dependencies to v1.46.3 ([#3657](googleapis/sdk-platform-java#3657)) ([79b7ba6](googleapis/sdk-platform-java@79b7ba6)) * update grpc to 1.70.0 ([#3641](googleapis/sdk-platform-java#3641)) ([945bd47](googleapis/sdk-platform-java@945bd47)) * update grpc to 1.70.0 (missed update) ([#3658](googleapis/sdk-platform-java#3658)) ([41fed1b](googleapis/sdk-platform-java@41fed1b)) * Update opentelemetry-semconv to v1.29.0-alpha ([#3635](googleapis/sdk-platform-java#3635)) ([9297f92](googleapis/sdk-platform-java@9297f92)) ### Documentation * update showcase readme ([#3659](googleapis/sdk-platform-java#3659)) ([f4b913e](googleapis/sdk-platform-java@f4b913e)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Joe Wang <joewa@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is working if the javadoc_test job fails.