spanner: Options: Fix null dereference, expand test coverage#3706
Merged
pongad merged 3 commits intogoogleapis:masterfrom Sep 26, 2018
nithinsujir:optcovg
Merged
spanner: Options: Fix null dereference, expand test coverage#3706pongad merged 3 commits intogoogleapis:masterfrom nithinsujir:optcovg
pongad merged 3 commits intogoogleapis:masterfrom
nithinsujir:optcovg
Conversation
The equals code does not handle the comparison of two Options objects where only one of them has either limit, pageSize or prefetchChunks defined. The argument to Object.equals() takes for instance limit() and this tries to deref the null to convert it to a long. Add hasXXX() checks before calling Object.equals(). This patch also removes functions that will not be called since they are internal.
This expands coverage of Options to 100%.
googlebot
added
the
cla: yes
nithinsujir
changed the title
Author
|
R: @biswanag |
nithinsujir
changed the title
suztomo
pushed a commit
that referenced
this pull request
Mar 9, 2026
lqiu96
pushed a commit
that referenced
this pull request
Mar 20, 2026
chingor13
pushed a commit
that referenced
this pull request
Mar 24, 2026
In this PR: - Setup logging module structure.
chingor13
pushed a commit
that referenced
this pull request
Mar 24, 2026
A follow up of #3706: - Change the group id to `com.google.cloud` as it is a customer-facing library. - Add clirr and enforcer check in CI.
chingor13
pushed a commit
that referenced
this pull request
Mar 24, 2026
* feat: add default_isolation_level connection property Add a `default_isolation_level` property for the Connection API. This property will be used by the JDBC driver and PGAdapter to set a default isolation level for all read/write transactions that are executed by a connection. Support for setting an isolation level for a single transaction will be added in a follow-up pull request. * feat: specify isolation level per transaction Add an option to specify the isolation level for a single transaction. This isolation level overrides the current default isolation level that has been set for the connection. This option only has an effect for read/write transactions. * feat: support PostgreSQL isolation level statements Adds support for PostgreSQL-dialect SQL statements for setting the isolation level of a transaction. * chore: generate libraries at Fri Mar 28 11:51:13 UTC 2025 --------- Co-authored-by: cloud-java-bot <cloud-java-bot@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Options coverage now at 100%