Skip to content

[Storage] Add launch stage annotations around bucket lock methods#3764

Merged
chingor13 merged 2 commits intomasterfrom
bucket-lock-launch-annotation
Oct 3, 2018
Merged

[Storage] Add launch stage annotations around bucket lock methods#3764
chingor13 merged 2 commits intomasterfrom
bucket-lock-launch-annotation

Conversation

@frankyn
Copy link
Copy Markdown
Contributor

@frankyn frankyn commented Oct 3, 2018

No description provided.

@frankyn frankyn requested a review from chingor13 October 3, 2018 19:24
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 3, 2018
abstract Builder setKmsKeyName(String kmsKeyName);

/** Sets the blob's event-based hold. */
@GcpLaunchStage.Beta

This comment was marked as spam.

This comment was marked as spam.

@frankyn
Copy link
Copy Markdown
Contributor Author

frankyn commented Oct 3, 2018

@chingor13 will merge when kokoro tests pass.

@chingor13 chingor13 merged commit 7f74c5a into master Oct 3, 2018
@frankyn frankyn deleted the bucket-lock-launch-annotation branch October 3, 2018 22:23
suztomo pushed a commit that referenced this pull request Mar 9, 2026
lqiu96 pushed a commit that referenced this pull request Mar 20, 2026
chingor13 pushed a commit that referenced this pull request Mar 24, 2026
https://github.com/googleapis/java-storage/actions/runs/14629392782/job/41048556919
was a failed run of update_generation_config.sh.

The error message was misleading since jq failed because the command
that produced the input for such jq command had silently failed:

```
Updating files: 100% (7136/7136), done.
~/work/java-storage/java-storage/tmp-googleapis ~/work/java-storage/java-storage
Already up to date.
~/work/java-storage/java-storage
Update googleapis_commitish to 03baf05e13d9241ec8c19bdedb1d991b6ed7e115 in generation_config.yaml
jq: parse error: Invalid numeric literal at line 1, column 7
Error: Process completed with exit code 1.
```

If we enable the `xtrace` flag, we can see it was due to a 502 when
fetching the latest version of the generator:
```
Updating files: 100% (7136/7136), done.
+ pushd tmp-googleapis
~/google/java-storage/tmp-googleapis ~/google/java-storage
+ git pull
Already up to date.
++ git rev-parse HEAD
+ latest_commit=03baf05e13d9241ec8c19bdedb1d991b6ed7e115
+ popd
~/google/java-storage
+ rm -rf tmp-googleapis
+ update_config googleapis_commitish 03baf05e13d9241ec8c19bdedb1d991b6ed7e115 generation_config.yaml
+ local key_word=googleapis_commitish
+ local new_value=03baf05e13d9241ec8c19bdedb1d991b6ed7e115
+ local file=generation_config.yaml
+ echo 'Update googleapis_commitish to 03baf05e13d9241ec8c19bdedb1d991b6ed7e115 in generation_config.yaml'
Update googleapis_commitish to 03baf05e13d9241ec8c19bdedb1d991b6ed7e115 in generation_config.yaml
+ sed -i -e 's/^googleapis_commitish.*$/googleapis_commitish: 03baf05e13d9241ec8c19bdedb1d991b6ed7e115/' generation_config.yaml
++ get_latest_released_version com.google.api gapic-generator-java
++ local group_id=com.google.api
++ local artifact_id=gapic-generator-java
+++ curl -s 'https://search.maven.org/solrsearch/select?q=g:com.google.api+AND+a:gapic-generator-java&core=gav&rows=500&wt=json'
++ json_content='<html>
<head><title>502 Bad Gateway</title></head>
<body>
<center><h1>502 Bad Gateway</h1></center>
</body>
</html>'
+++ jq -r '.response.docs[] | select(.v | test("^[0-9]+(\\.[0-9]+)*$")) | .v'
+++ sort -V
+++ tail -n 1
jq: parse error: Invalid numeric literal at line 2, column 0
++ latest=
++ [[ -z '' ]]
++ echo 'The latest version of com.google.api:gapic-generator-java is empty.'
++ echo 'The returned json from maven.org is invalid: <html>
<head><title>502 Bad Gateway</title></head>
<body>
<center><h1>502 Bad Gateway</h1></center>
</body>
</html>'
++ exit 1
+ latest_version='The latest version of com.google.api:gapic-generator-java is empty.
The returned json from maven.org is invalid: <html>
<head><title>502 Bad Gateway</title></head>
<body>
<center><h1>502 Bad Gateway</h1></center>
</body>
</html>'
```

Such flag saves the developer a round trip for local reproduction.
chingor13 pushed a commit that referenced this pull request Mar 24, 2026
🤖 I have created a release *beep* *boop*
---


<details><summary>2.61.0</summary>

##
[2.61.0](googleapis/sdk-platform-java@v2.60.2...v2.61.0)
(2025-08-04)


### Features

* **mtls:** Add support for X.509-based mTLS-transport in Java GAX lib
([#3852](googleapis/sdk-platform-java#3852))
([ebca20e](googleapis/sdk-platform-java@ebca20e))


### Bug Fixes

* improve error messaging for LRO CancellationException
([#3873](googleapis/sdk-platform-java#3873))
([2759998](googleapis/sdk-platform-java@2759998))
* make generation config update logs verbose
([#3764](googleapis/sdk-platform-java#3764))
([54e7a23](googleapis/sdk-platform-java@54e7a23))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants