Skip to content

Make StandardTableDefinition$StreamingBuffer/getEstimatedRows nullable#4178

Closed
mikekap wants to merge 1 commit intogoogleapis:masterfrom
mikekap:patch-2
Closed

Make StandardTableDefinition$StreamingBuffer/getEstimatedRows nullable#4178
mikekap wants to merge 1 commit intogoogleapis:masterfrom
mikekap:patch-2

Conversation

@mikekap
Copy link

@mikekap mikekap commented Dec 5, 2018

They're already Long - currently calling the accessors will throw an exception if those are actually null.

@mikekap mikekap requested a review from a team December 5, 2018 05:57
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 5, 2018
@chingor13 chingor13 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 5, 2018
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 5, 2018
@mikekap
Copy link
Author

mikekap commented Dec 10, 2018

Caused by: io.grpc.StatusRuntimeException: RESOURCE_EXHAUSTED: Quota exceeded for quota metric 'logging.googleapis.com/read_requests' and limit 'ReadRequestsPerMinutePerProject' of service 'logging.googleapis.com' for consumer 'project_number:1016721519174'.

I don't think that's related to my change.

@mikekap
Copy link
Author

mikekap commented Jan 6, 2019

Looks like this was fixed by #4247

@mikekap mikekap closed this Jan 6, 2019
chingor13 pushed a commit that referenced this pull request Mar 24, 2026
…v3.53.0 (#4178)

* deps: update dependency com.google.cloud:sdk-platform-java-config to v3.53.0

* chore: Add failureaccess to exclusion as it is managed by guava

---------

Co-authored-by: rahul2393 <irahul@google.com>
Co-authored-by: Lawrence Qiu <lawrenceqiu@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants