Skip to content

Regenerate container client#4360

Closed
yoshi-automation wants to merge 1 commit intomasterfrom
autosynth-container
Closed

Regenerate container client#4360
yoshi-automation wants to merge 1 commit intomasterfrom
autosynth-container

Conversation

@yoshi-automation
Copy link
Contributor

@yoshi-automation yoshi-automation commented Jan 17, 2019

This PR was generated using Autosynth. 🌈

Here's the log from Synthtool:

synthtool > Executing /tmpfs/src/git/autosynth/working_repo/google-cloud-clients/google-cloud-container/synth.py.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
latest: Pulling from googleapis/artman
Digest: sha256:12722f2ca3fbc3b53cc6aa5f0e569d7d221b46bd876a2136497089dec5e3634e
Status: Image is up to date for googleapis/artman:latest
synthtool > Cloning googleapis.
synthtool > Running generator for google/container/artman_container_v1.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/java.
synthtool > Running java formatter on 12 files
synthtool > Running java formatter on 1 files
synthtool > Running java formatter on 119 files
synthtool > Cleaned up 0 temporary directories.
synthtool > Wrote metadata to synth.metadata.

@yoshi-automation yoshi-automation requested a review from a team January 17, 2019 08:38
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 17, 2019
@chingor13 chingor13 mentioned this pull request Jan 17, 2019
Merged
@chingor13
Copy link
Contributor

chingor13 commented Jan 17, 2019

Combined into a single pull request #4382

@chingor13 chingor13 closed this Jan 17, 2019
chingor13 pushed a commit that referenced this pull request Mar 24, 2026
@olavloite
fix: retry CreateSession also when waitForMinSessions is zero (#4360)
7ae4d2e 
* fix: retry CreateSession also when waitForMinSessions is zero

The creation of a session at startup would only be retried if waitForMinSessions was set.
This changed introduces retries for CreateSession at startup if the error code is
potentially transient. The number of retries is set to maximum 10.

* chore: address review comment + fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yoshi-automation @chingor13 @googlebot