Skip to content

feat(librarian): support legacylibrarian "release-only" mode#16130

Open
jskeet wants to merge 1 commit intogoogleapis:mainfrom
jskeet:legacylibrarian-release-only-mode
Open

feat(librarian): support legacylibrarian "release-only" mode#16130
jskeet wants to merge 1 commit intogoogleapis:mainfrom
jskeet:legacylibrarian-release-only-mode

Conversation

@jskeet
Copy link
Contributor

@jskeet jskeet commented Mar 19, 2026

When we have migrated generation to librarian, we will still use legacylibrarian for releasing - including the Docker image used to bump versions. However, in that mode legacylibrarian won't provide a list of changes, so we shouldn't update the per-library changelog files.

Fixes googleapis/librarian#4660

When we have migrated generation to librarian, we will still use
legacylibrarian for releasing - including the Docker image used to
bump versions. However, in that mode legacylibrarian won't provide a
list of changes, so we shouldn't update the per-library changelog
files.
@jskeet jskeet requested review from a team as code owners March 19, 2026 14:02
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a crucial adjustment to the release workflow, enabling compatibility with legacylibrarian when it operates in a 'release-only' capacity. The primary goal is to prevent the system from attempting to update per-library changelogs when the underlying legacylibrarian process does not supply the necessary change information, streamlining the migration to librarian while still leveraging legacylibrarian for specific release tasks.

Highlights

  • Optional Changelog Updates: Modified the release process to conditionally update changelogs. The changes data for a library release is now treated as optional, preventing changelog updates when this information is not provided.
  • Support for 'release-only' mode: Implemented support for legacylibrarian's 'release-only' mode, where it does not provide a list of changes. This ensures that per-library changelog files are not updated unnecessarily in this specific scenario.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for a 'release-only' mode where changelog data may not be present. The changes correctly handle the optional 'changes' field by using dict.get() and conditionally calling the changelog update function. I have one suggestion to make the conditional check more robust by checking for truthiness, which would also handle cases where the changes are present but empty.

@jskeet jskeet enabled auto-merge (squash) March 19, 2026 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

google-cloud-python: adapt legacylibrarian container for release-only mode

2 participants