Skip to content
This repository was archived by the owner on Mar 26, 2026. It is now read-only.

chore: demo of error when deleting an empty set of keys#4023

Closed
diegomarquezp wants to merge 2 commits intomainfrom
demo-delete-empty
Closed

chore: demo of error when deleting an empty set of keys#4023
diegomarquezp wants to merge 2 commits intomainfrom
demo-delete-empty

Conversation

@diegomarquezp
Copy link
Contributor

@diegomarquezp diegomarquezp commented Aug 18, 2025 •
edited
Loading

This PR demonstrates how to reproduce the following error when issuing a write() with a Mutation with an empty keyset:

    KeySet keySet = KeySet.newBuilder().build();
    Mutation emptyMutation = Mutation.delete("TestTable", keySet);
com.google.cloud.spanner.SpannerException: INVALID_ARGUMENT: io.grpc.StatusRuntimeException: INVALID_ARGUMENT: Failed to initialize transaction due to invalid mutation key.

	at com.google.cloud.spanner.SpannerExceptionFactory.newSpannerExceptionPreformatted(SpannerExceptionFactory.java:396)
	at com.google.cloud.spanner.SpannerExceptionFactory.newSpannerException(SpannerExceptionFactory.java:223)
	at com.google.cloud.spanner.SpannerExceptionFactory.newSpannerException(SpannerExceptionFactory.java:135)
	at com.google.cloud.spanner.TransactionRunnerImpl$TransactionContextImpl.commit(TransactionRunnerImpl.java:373)
	at com.google.cloud.spanner.TransactionRunnerImpl.lambda$runInternal$0(TransactionRunnerImpl.java:1336)
	at com.google.api.gax.retrying.DirectRetryingExecutor.submit(DirectRetryingExecutor.java:102)
	at com.google.cloud.RetryHelper.run(RetryHelper.java:76)
	at com.google.cloud.RetryHelper.runWithRetries(RetryHelper.java:50)
	at com.google.cloud.spanner.SpannerRetryHelper.runTxWithRetriesOnAborted(SpannerRetryHelper.java:91)
	at com.google.cloud.spanner.SpannerRetryHelper.runTxWithRetriesOnAborted(SpannerRetryHelper.java:70)
	at com.google.cloud.spanner.TransactionRunnerImpl.runInternal(TransactionRunnerImpl.java:1352)
	at com.google.cloud.spanner.TransactionRunnerImpl.run(TransactionRunnerImpl.java:1252)
	at com.google.cloud.spanner.MultiplexedSessionTransactionRunner.run(MultiplexedSessionDatabaseClient.java:98)
	at com.google.cloud.spanner.SessionImpl.writeWithOptions(SessionImpl.java:250)
	at com.google.cloud.spanner.MultiplexedSessionDatabaseClient.writeWithOptions(MultiplexedSessionDatabaseClient.java:674)
	at com.google.cloud.spanner.DatabaseClientImpl.writeWithOptions(DatabaseClientImpl.java:209)
	at com.google.cloud.spanner.DatabaseClientImpl.write(DatabaseClientImpl.java:199)
	at com.google.cloud.spanner.it.ITReadTest.testWriteEmptyMutations(ITReadTest.java:548)
	Caused by: com.google.cloud.spanner.SpannerException: INVALID_ARGUMENT: io.grpc.StatusRuntimeException: INVALID_ARGUMENT: Failed to initialize transaction due to invalid mutation key.

@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: spanner Issues related to the googleapis/java-spanner API. labels Aug 18, 2025
@diegomarquezp diegomarquezp mentioned this pull request Aug 18, 2025
Closed
@diegomarquezp
Copy link
Contributor Author

diegomarquezp commented Aug 19, 2025

Confirmed error only occurs in multiplexed ITs: https://btx.cloud.google.com/invocations/aafe5fbf-6da5-4f69-87ff-fb1861ea9cb2/log

@zhumin8 zhumin8 mentioned this pull request Aug 19, 2025
Merged
zhumin8 added a commit to GoogleCloudPlatform/spring-cloud-gcp that referenced this pull request Aug 19, 2025
@zhumin8
fix: check for empty before delete (#4047)
b50c092 
spanner IT fails for `deleteAllById_doesNothingOnEmptyIds` test with error from Spanner:
`INVALID_ARGUMENT: Failed to initialize transaction due to invalid mutation key.`

**Trigger of this behavior change:**
spanner activated multiplexed sessions by default in [googleapis/java-spanner#3996](googleapis/java-spanner#3996), which triggers this error. 
When issuing a write() with a Mutation that has an empty KeySet produces an exception in Multiplexed clients (see [pr](googleapis/java-spanner#4023)), but does a no-op in non-multiplexed ones. Unlike Regular session, multiplex session needs a valid mutation to generate a precommit token.

Fixes #4046
zhumin8 added a commit to GoogleCloudPlatform/spring-cloud-gcp that referenced this pull request Aug 19, 2025
@zhumin8
fix(spanner): check for empty before delete (#4047)
864871e 
spanner IT fails for `deleteAllById_doesNothingOnEmptyIds` test with error from Spanner:
`INVALID_ARGUMENT: Failed to initialize transaction due to invalid mutation key.`

**Trigger of this behavior change:**
spanner activated multiplexed sessions by default in [googleapis/java-spanner#3996](googleapis/java-spanner#3996), which triggers this error.
When issuing a write() with a Mutation that has an empty KeySet produces an exception in Multiplexed clients (see [pr](googleapis/java-spanner#4023)), but does a no-op in non-multiplexed ones. Unlike Regular session, multiplex session needs a valid mutation to generate a precommit token.

Fixes #4046
@zhumin8 zhumin8 mentioned this pull request Aug 19, 2025
Merged
zhumin8 added a commit to GoogleCloudPlatform/spring-cloud-gcp that referenced this pull request Aug 19, 2025
@zhumin8
fix(spanner): check for empty before delete (#4047)
792aeca 
spanner IT fails for `deleteAllById_doesNothingOnEmptyIds` test with error from Spanner:
`INVALID_ARGUMENT: Failed to initialize transaction due to invalid mutation key.`

**Trigger of this behavior change:**
spanner activated multiplexed sessions by default in [googleapis/java-spanner#3996](googleapis/java-spanner#3996), which triggers this error.
When issuing a write() with a Mutation that has an empty KeySet produces an exception in Multiplexed clients (see [pr](googleapis/java-spanner#4023)), but does a no-op in non-multiplexed ones. Unlike Regular session, multiplex session needs a valid mutation to generate a precommit token.

Fixes #4046
@zhumin8 zhumin8 mentioned this pull request Aug 19, 2025
Merged
zhumin8 added a commit to GoogleCloudPlatform/spring-cloud-gcp that referenced this pull request Aug 19, 2025
@zhumin8
fix(spanner): check for empty before delete (#4047)
93e1fc8 
spanner IT fails for `deleteAllById_doesNothingOnEmptyIds` test with error from Spanner:
`INVALID_ARGUMENT: Failed to initialize transaction due to invalid mutation key.`

**Trigger of this behavior change:**
spanner activated multiplexed sessions by default in [googleapis/java-spanner#3996](googleapis/java-spanner#3996), which triggers this error.
When issuing a write() with a Mutation that has an empty KeySet produces an exception in Multiplexed clients (see [pr](googleapis/java-spanner#4023)), but does a no-op in non-multiplexed ones. Unlike Regular session, multiplex session needs a valid mutation to generate a precommit token.

Fixes #4046
@zhumin8 zhumin8 mentioned this pull request Aug 19, 2025
Merged
zhumin8 added a commit to GoogleCloudPlatform/spring-cloud-gcp that referenced this pull request Aug 19, 2025
@zhumin8
fix(spanner): check for empty before delete (#4047) (#4077)
cb1f687 
backport fix from #4047

spanner IT fails for `deleteAllById_doesNothingOnEmptyIds` test with
error from Spanner: `INVALID_ARGUMENT: Failed to initialize transaction
due to invalid mutation key.`

**Trigger of this behavior change:**
spanner activated multiplexed sessions by default in
[googleapis/java-spanner#3996](googleapis/java-spanner#3996),
which triggers this error. When issuing a write() with a Mutation that
has an empty KeySet produces an exception in Multiplexed clients (see
[pr](googleapis/java-spanner#4023)), but does a
no-op in non-multiplexed ones. Unlike Regular session, multiplex session
needs a valid mutation to generate a precommit token.

Fixes #4046
zhumin8 added a commit to GoogleCloudPlatform/spring-cloud-gcp that referenced this pull request Aug 19, 2025
@zhumin8
fix(spanner): check for empty before delete (#4047) (#4078)
319cf41 
Backport fix.


spanner IT fails for `deleteAllById_doesNothingOnEmptyIds` test with
error from Spanner: `INVALID_ARGUMENT: Failed to initialize transaction
due to invalid mutation key.`

**Trigger of this behavior change:**
spanner activated multiplexed sessions by default in
[googleapis/java-spanner#3996](googleapis/java-spanner#3996),
which triggers this error. When issuing a write() with a Mutation that
has an empty KeySet produces an exception in Multiplexed clients (see
[pr](googleapis/java-spanner#4023)), but does a
no-op in non-multiplexed ones. Unlike Regular session, multiplex session
needs a valid mutation to generate a precommit token.
zhumin8 added a commit to GoogleCloudPlatform/spring-cloud-gcp that referenced this pull request Aug 19, 2025
@zhumin8
fix(spanner): check for empty before delete (#4047) (#4079)
e0a2716 
Backport fix.

spanner IT fails for `deleteAllById_doesNothingOnEmptyIds` test with
error from Spanner: `INVALID_ARGUMENT: Failed to initialize transaction
due to invalid mutation key.`

**Trigger of this behavior change:**
spanner activated multiplexed sessions by default in
[googleapis/java-spanner#3996](googleapis/java-spanner#3996),
which triggers this error. When issuing a write() with a Mutation that
has an empty KeySet produces an exception in Multiplexed clients (see
[pr](googleapis/java-spanner#4023)), but does a
no-op in non-multiplexed ones. Unlike Regular session, multiplex session
needs a valid mutation to generate a precommit token.

Fixes #4046
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

api: spanner Issues related to the googleapis/java-spanner API. size: xl Pull request size is extra large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@diegomarquezp @cloud-java-bot