fix(db_api): move connection validation into a separate method#543
Merged
skuruppu merged 6 commits intogoogleapis:mainfrom Sep 7, 2021
Merged
fix(db_api): move connection validation into a separate method#543skuruppu merged 6 commits intogoogleapis:mainfrom
skuruppu merged 6 commits intogoogleapis:mainfrom
Conversation
IlyaFaer
added
the
api: spanner
google-cla
bot
added
the
cla: yes
IlyaFaer
commented
Aug 27, 2021
larkee
suggested changes
Aug 29, 2021
Contributor
larkee
left a comment
larkee
left a comment
There was a problem hiding this comment.
This PR will not behave as intended against production. Please add system tests.
added 2 commits
August 30, 2021 11:21
larkee
approved these changes
Sep 2, 2021
Contributor
larkee
left a comment
larkee
left a comment
There was a problem hiding this comment.
LGTM with the docstring addition
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Sep 21, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [3.10.0](https://github.com/googleapis/python-spanner/compare/v3.9.0...v3.10.0) (2021-09-17) ### Features * set a separate user agent for the DB API ([#566](https://github.com/googleapis/python-spanner/issues/566)) ([b5f977e](https://github.com/googleapis/python-spanner/commit/b5f977ebf61527914af3c8356aeeae9418114215)) ### Bug Fixes * **db_api:** move connection validation into a separate method ([#543](https://github.com/googleapis/python-spanner/issues/543)) ([237ae41](https://github.com/googleapis/python-spanner/commit/237ae41d0c0db61f157755cf04f84ef2d146972c)) * handle google.api_core.exceptions.OutOfRange exception and throw InegrityError as expected by dbapi standards ([#571](https://github.com/googleapis/python-spanner/issues/571)) ([dffcf13](https://github.com/googleapis/python-spanner/commit/dffcf13d10a0cfb6b61231ae907367563f8eed87)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes googleapis/python-spanner-sqlalchemy#104