Don't use executor in run_http_query when return_promise=True#33
Merged
Cito merged 2 commits intographql-python:masterfrom Jan 23, 2020
Merged
Don't use executor in run_http_query when return_promise=True#33Cito merged 2 commits intographql-python:masterfrom
Cito merged 2 commits intographql-python:masterfrom
Conversation
blazewicz
force-pushed
the
return-promise-option
branch
3 times, most recently
from
3e9d42d to
24fbb7f
Compare
blazewicz
force-pushed
the
return-promise-option
branch
from
24fbb7f to
845ea85
Compare
|
This all looks good to me, I discovered this issue in my application as well. @Cito I notice you're one of the main contributors to this project after @syrusakbary opened it up to the community, are there any contributing/review guidelines we should be following? |
ItsAshleyJ182
approved these changes
Jan 15, 2020
|
@Cito is there anyone else who has write access to this repository? We should really address this issue |
Member
|
@banjoanderson was swamped with work - will have a look later today. |
Member
|
Thanks a lot for working on this. I will create a 1.2 release containing this fix. |
Member
|
Version 1.2.0 has been released now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #32