Skip to content

feat: implement SOPS secret provider#8

Open
tonnico wants to merge 3 commits intohaloydev:mainfrom
tonnico:feat/sops-secrets
Open

feat: implement SOPS secret provider#8
tonnico wants to merge 3 commits intohaloydev:mainfrom
tonnico:feat/sops-secrets

Conversation

@tonnico
Copy link
Copy Markdown

@tonnico tonnico commented Mar 31, 2026

solves #6

@tonnico tonnico force-pushed the feat/sops-secrets branch from 17f4997 to a531f04 Compare March 31, 2026 11:07
@ameistad
Copy link
Copy Markdown
Contributor

Nice! Looks good overall.

I found two issues:

  1. In internal/configloader/resolve_secrets.go, the sops case uses := when loading sourceConfig and found. That shadows the outer variables, so the outer found remains false and SOPS sources are always treated as undefined.

  2. In the same file, extractValues still parses secret refs using . instead of :. With the new syntax likesops:development:client.id, this can panic when resolving secrets.

@tonnico
Copy link
Copy Markdown
Author

tonnico commented Apr 3, 2026

Many thanks for your review. I'm pretty new in golang.

I'm currently on holiday and will take a look next week on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants