Format code automatically during compile using google-java-format#53
Merged
andylintner merged 2 commits intohap-java:masterfrom Feb 3, 2019
Merged
Conversation
There's lot of inconsistent uses of tabs vs spaces throughout the project, and this is leading to some weird diffs. I submit the project should just enforce formatting during compile time and just remove any doubt. This way contributors won't need to update their Eclipse configuration to match, as long as they run mvn compile, it'll format correctly.
timcharper
force-pushed
the
tharper/use-google-code-formatter
branch
from
aae4774 to
adf7af0
Compare
Contributor
Author
|
I've split this PR up in to two commits; 2008ca8 just adds the plugin, and then adf7af0 adds the result of running the formatter. It gives me a ton of credit, so you may wish to just merge the first commit and then run and commit the results yourself :) Ignoring whitespace makes the 2nd patch easier to read. |
Contributor
Author
|
@beowulfe any opinion on this? |
Collaborator
|
Thanks for doing that @timcharper - much cleaner! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's lot of inconsistent uses of tabs vs spaces throughout the project, and
this is leading to some weird diffs. I submit the project should just enforce
formatting during compile time and just remove any doubt. This way contributors
won't need to update their Eclipse configuration to match, as long as they run
mvn compile, it'll format correctly.