Add --local flag to login and ci commands#261
Open
github-actions[bot] wants to merge 1 commit intomainfrom
Open
Add --local flag to login and ci commands#261github-actions[bot] wants to merge 1 commit intomainfrom
github-actions[bot] wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
hookdeck loginandhookdeck cilacked a--localflag, making it impossible to save directory-specific credentials to.hookdeck/config.tomlwithout the less-discoverable global--configworkaround. This was inconsistent withhookdeck project use --local.Solution
Added
--localflag to bothloginandcicommands following the same pattern asproject use --local:--localis set, credentials (API key, project ID, project mode) are written to.hookdeck/config.tomlin the current directory via the existingConfig.UseProjectLocal()method..hookdeck/directory is created if it does not exist..hookdeck/to.gitignore.--localtogether with--configreturns a clear error.saveLocalConfig()helper inlogin.gois reused by both commands to avoid duplication.