Open
Conversation
findtext: const char * heap_caps_free instead of heap_caps_aligned_free const char * _div[] add return to _rand displayStat: const char *
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
getChildAtPos returns NULL when out of bounds — that's the confirmed null. The fix belongs in findMaxArgumentSize() in NodeToken.h. Root cause: when an addExternal-registered function (like random16) is used as a nested argument expression (not a statement), ESPLiveScript builds its AST node without children 1 and 2. findMaxArgumentSize() enters the extCallFunctionNode branch and immediately dereferences getChildAtPos(1) without a null check → crash. The fix — add null guards before the two dereferences in findMaxArgumentSize(): Why returning cur_size (0) is semantically correct: findMaxArgumentSize() tells _visitCallFunctionTemplate whether an argument needs stack-spilling before the outer call. The check is findMaxArgumentSize() - 1 >= i — for a scalar like uint16_t from random16, the correct answer is 0 (fits in one register, no spill). Arithmetic expressions like y*width+x also return 0 via the else branch. The early-return preserves that behaviour for nested extern scalars. PR description for the ESPLiveScript repo: ▎ findMaxArgumentSize() crashes when an addExternal-registered function is used as a nested argument expression (e.g. setRGB(random16(n), color)). When an extern call is built as a sub-expression rather than a statement, children 1 and 2 are not populated; the existing code dereferences getChildAtPos(1) unconditionally → null-deref / LoadProhibited on ESP32. ▎ Fix: guard both getChildAtPos(1) and getChildAtPos(2) and return early with 0 if either is null. Zero is the correct return value for a scalar nested extern call (same as arithmetic sub-expressions).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
findtext: const char *
heap_caps_free instead of heap_caps_aligned_free
const char * _div[]
add return to _rand
displayStat: const char *