Merged
Conversation
This is the latest version of rubocop with most of the auto-corrects run. There are a few notes on this: - Performance cops have been refactored out so they require being installed in a new gem. That gem has been included so that we can keep performance cops. - I left out the Alight Hash cop because the code base has it going both ways. I want to put that in its own commit so that it is easy to change or reverse if the maintainers want to go one way or another.
ixti
reviewed
May 8, 2019
.rubocop.yml
Outdated
| Layout/SpaceInsideHashLiteralBraces: | ||
| EnforcedStyle: no_space | ||
|
|
||
| Layout/AlignHash: |
Member
There was a problem hiding this comment.
Please put this at the before Layout/DotPosition (so that they are alphabetically sorted.
Contributor
Author
There was a problem hiding this comment.
Done and rebased.
ixti
reviewed
May 8, 2019
Member
ixti
left a comment
ixti
left a comment
There was a problem hiding this comment.
Other than rubocop config order, LGTM.
This commit enables Layout/AlignHash and sets the prefered format to the table format. The docs for this cop can be found here: https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Layout/AlignHash
natesholland
force-pushed
the
natesholland/rubocop_upgrade_0_68
branch
from
bc4627e to
90f8213
Compare
Contributor
Author
|
@ixti done and ready to go. |
ixti
approved these changes
May 9, 2019
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #548 I upgraded RuboCop by about 10 versions. In this PR I'm following up to upgrade to the latest version of RuboCop. All the changes in this PR are a result of the auto-correct flags so I didn't edit any code manually.
There are two specific items that I want to call out in this PR:
rubocop-performanceis now its own gem that can be found here https://github.com/rubocop-hq/rubocop-performance. I suspect that we still want the performance cops to keep this project as performant as possible. Therefore I pulled the gem in and required the performance cops to keep them running. I tested to ensure that we are in fact still running performance cops.tableand thenkeyand then I think `separator is clearly the weirdest and worst.