update unet_2d.py and AttnUpBlock2D#2770
Closed
QishengL wants to merge 5 commits intohuggingface:mainfrom
Closed
Conversation
AttnUpBlock2D add upsample_size paramerter
AttnUpBlock2D add upsample_size paramerter
Add upsample_size
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
Contributor
|
Hey @QishengL, Thanks for the PR, could you try to add a test as well here? :-) |
Author
|
Contributor
|
Hey @QishengL, Sorry I think I wasn't super clear - I was wondering if you could add a test here: that checks that the unet can process an input that is just a multiple of 8 |
Contributor
|
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to generate some images based on unet_2d and got the same error in #255. #505 fixed this problem.
As #505, unet_2d_conditon.py and CrossAttnUpBlock2D can work on images that are not multiples of 64, but unet_2d.py and AttnUpBlock2D are not updated.