Skip to content

explicit broadcasts for assignments#3535

Merged
patrickvonplaten merged 1 commit intohuggingface:mainfrom
williamberman:kernel_assignment_explicit_broadcast
May 24, 2023
Merged

explicit broadcasts for assignments#3535
patrickvonplaten merged 1 commit intohuggingface:mainfrom
williamberman:kernel_assignment_explicit_broadcast

Conversation

@williamberman
Copy link
Copy Markdown
Contributor

Fixing more errors from assignments with explicit broadcasts

FAILED tests/pipelines/stable_diffusion_2/test_stable_diffusion_latent_upscale.py::StableDiffusionLatentUpscalePipelineFastTests::test_cpu_offload_forward_pass - RuntimeError: linearIndex.numel()*sliceSize*nElemBefore == expandedValue.numel() INTERNAL ASSERT FAILED at "../aten/src/ATen/native/cuda/Indexing.cu":389, please report a bug to PyTorch. number of flattened indices did not match number of elements in the value tensor: 512 vs 16

@williamberman williamberman requested review from patrickvonplaten, pcuenca, sayakpaul and yiyixuxu and removed request for pcuenca May 23, 2023 20:55
@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

HuggingFaceDocBuilderDev commented May 23, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Copy Markdown
Member

@pcuenca pcuenca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting! Did assignment stop working at some point?

Copy link
Copy Markdown
Contributor

@patrickvonplaten patrickvonplaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool!

@patrickvonplaten patrickvonplaten merged commit db56f8a into huggingface:main May 24, 2023
@williamberman
Copy link
Copy Markdown
Contributor Author

@pcuenca I think it only happens when determinism is turned on and even then not every time, it's a really weird bug that I didn't dig into past that

yoonseokjin pushed a commit to yoonseokjin/diffusers that referenced this pull request Dec 25, 2023
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants