feat: add Dropout to Flax UNet#3894
Merged
pcuenca merged 12 commits intohuggingface:mainfrom Jul 7, 2023
SauravMaheshkar:saurav/add-dropout-flax-unet
Merged
feat: add Dropout to Flax UNet#3894pcuenca merged 12 commits intohuggingface:mainfrom SauravMaheshkar:saurav/add-dropout-flax-unet
Dropout to Flax UNet#3894pcuenca merged 12 commits intohuggingface:mainfrom
SauravMaheshkar:saurav/add-dropout-flax-unet
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
Contributor
|
cc @pcuenca |
pcuenca
reviewed
Jul 6, 2023
Member
pcuenca
left a comment
pcuenca
left a comment
There was a problem hiding this comment.
Thanks for this! I just have a question about the use of nn.compact and then we can merge.
| tensor = tensor.reshape(batch_size // head_size, seq_len, dim * head_size) | ||
| return tensor | ||
|
|
||
| @nn.compact |
Member
There was a problem hiding this comment.
There's already a setup method in this class, it's a bit weird (to me) that we also use nn.compact. Would it be feasible to add nn.Dropout as a module in setup instead?
yoonseokjin
pushed a commit
to yoonseokjin/diffusers
that referenced
this pull request
Dec 25, 2023
* feat: add Dropout to Flax UNet * feat: add @compact decorator * fix: drop nn.compact
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
* feat: add Dropout to Flax UNet * feat: add @compact decorator * fix: drop nn.compact
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #522
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Request for Review: @patrickvonplaten