Fix guess_mode in StableDiffusionXLControlNetPipeline#4725
Closed
YashalKanungo wants to merge 1 commit intohuggingface:mainfrom
Closed
Fix guess_mode in StableDiffusionXLControlNetPipeline#4725YashalKanungo wants to merge 1 commit intohuggingface:mainfrom
YashalKanungo wants to merge 1 commit intohuggingface:mainfrom
Conversation
Chunk and use single add_text_embeds and add_time_ids when using guess_mode and do_classifier_free_guidance
Member
|
Being addressed in #4155. So, closing this one. Thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix guess_mode in StableDiffusionXLControlNetPipeline
What does this PR do?
It fixes a bug due to which guess mode was not usable in StableDiffusionXLControlNetPipeline.
Reproducing the original bug
Following the example at https://huggingface.co/diffusers/controlnet-canny-sdxl-1.0
if we set
guess_mode=Trueit throws the error,
Fixes
During ControlNet inference for only the conditional batch, also only use the corresponding
add_text_embedsandadd_time_ids.Tests
guess_mode=TrueBefore submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?