fix bug in StableDiffusionXLControlNetPipeline when use guess_mode#4799
Merged
fix bug in StableDiffusionXLControlNetPipeline when use guess_mode#4799
Conversation
added 2 commits
August 27, 2023 05:16
|
The documentation is not available anymore as the PR was closed or merged. |
Contributor
|
Cool! One quick fast/dummy test for this one? |
Contributor
|
Very nice! Looks good to me - let's maybe add this also to our SDXL controlnet docs in a follow-up PR (cc @stevhliu) Think the test is also currently failing on the CI - can we make it more deterministic? |
added 2 commits
August 28, 2023 09:00
…ers into sdxl-controlnet-guess
patrickvonplaten
approved these changes
Aug 28, 2023
Contributor
patrickvonplaten
left a comment
There was a problem hiding this comment.
Cool! @sayakpaul maybe for a final review?
sayakpaul
approved these changes
Aug 28, 2023
Member
sayakpaul
left a comment
There was a problem hiding this comment.
The logic definitely reads simplistic now. Thank you!
yoonseokjin
pushed a commit
to yoonseokjin/diffusers
that referenced
this pull request
Dec 25, 2023
…uggingface#4799) * fix --------- Co-authored-by: yiyixuxu <yixu310@gmail,com> Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com>
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
…uggingface#4799) * fix --------- Co-authored-by: yiyixuxu <yixu310@gmail,com> Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fix a bug in sdxl controlnet when
guess_mode=TrueIt fix #4709 and I think it does the same thing as #4155 but we don't need to drastically change the code structure