JAX/Flax safety checker by pcuenca · Pull Request #558 · huggingface/diffusers

pcuenca · 2022-09-19T07:29:45Z

Docstrings and tests pending.

To test:

from transformers import CLIPFeatureExtractor
from diffusers.pipelines.stable_diffusion import FlaxStableDiffusionSafetyChecker

feature_extractor = CLIPFeatureExtractor.from_pretrained("openai/clip-vit-large-patch14")
safety_checker, params = FlaxStableDiffusionSafetyChecker.from_pretrained(
    "<model id>", dtype= jnp.bfloat16,
)

params = replicate(params)
unshard = lambda x: einops.rearrange(x, 'd b ... -> (d b) ...')

@jax.pmap
def get_safety_scores(features, params):
    special_cos_dist, cos_dist = safety_checker.apply({"params": params}, features)
    return (special_cos_dist, cos_dist)

def run_safety_checker(images):
    pil_images = [Image.fromarray(image) for image in images]
    jnp_images = jnp.array(images)
    jnp_images = shard(jnp_images)
    features = feature_extractor(pil_images, return_tensors="np").pixel_values
    features = jnp.transpose(features, (0, 2, 3, 1))
    features = shard(features)
    special_cos_dist, cos_dist = get_safety_scores(features, params)
    images, has_nsfw = safety_checker.apply(
        {"params": unreplicate(params)},
        unshard(special_cos_dist),
        unshard(cos_dist),
        images,
        method=safety_checker.filtered_with_scores
    )
    return images, has_nsfw

shape = (8, 512, 512, 3)
images = np.random.rand(*shape)
images = (images * 255).round().astype("uint8")
_, has_nsfw = run_safety_checker(images)

HuggingFaceDocBuilderDev · 2022-09-19T07:34:32Z

The documentation is not available anymore as the PR was closed or merged.

pcuenca · 2022-09-19T09:01:09Z

src/diffusers/pipelines/stable_diffusion/safety_checker_flax.py

+class FlaxStableDiffusionSafetyChecker(nn.Module, FlaxModelMixin, ConfigMixin):
+    projection_dim: int = 768
+    # CLIPVisionConfig fields
+    vision_config: dict = field(default_factory=dict)


The config file that is currently used contains all the CLIP configuration options. We just retrieve the ones corresponding to the CLIPVisionConfig that we use.

Does the saving & loading work correctly with it?
Think long-term what would be better is to actually just write the parameters that we would people like to change in here (e.g. the size of the CLIP, ....) and then use CLIP default config parameters (see suggestion below)

Does the saving & loading work correctly with it?

Loading works (from CLIP config files as the one currently in the fusing repo). I did not test saving yet, will do now.

Think long-term what would be better is to actually just write the parameters that we would people like to change

I thought about this approach, but there are many parameters in the configuration file and wasn't sure which ones we wanted to expose. In addition, it could still be useful to reuse any CLIP configuration json and just retrieve the vision part, instead of reading the parameters from the root of the json, which I presume would be incompatible with existing configurations.

These are all the relevant keys in the current configuration file:

"vision_config": { "_name_or_path": "", "add_cross_attention": false, "architectures": null, "attention_dropout": 0.0, "bad_words_ids": null, "bos_token_id": null, "chunk_size_feed_forward": 0, "cross_attention_hidden_size": null, "decoder_start_token_id": null, "diversity_penalty": 0.0, "do_sample": false, "dropout": 0.0, "early_stopping": false, "encoder_no_repeat_ngram_size": 0, "eos_token_id": null, "exponential_decay_length_penalty": null, "finetuning_task": null, "forced_bos_token_id": null, "forced_eos_token_id": null, "hidden_act": "quick_gelu", "hidden_size": 1024, "id2label": { "0": "LABEL_0", "1": "LABEL_1" }, "image_size": 224, "initializer_factor": 1.0, "initializer_range": 0.02, "intermediate_size": 4096, "is_decoder": false, "is_encoder_decoder": false, "label2id": { "LABEL_0": 0, "LABEL_1": 1 }, "layer_norm_eps": 1e-05, "length_penalty": 1.0, "max_length": 20, "min_length": 0, "model_type": "clip_vision_model", "no_repeat_ngram_size": 0, "num_attention_heads": 16, "num_beam_groups": 1, "num_beams": 1, "num_channels": 3, "num_hidden_layers": 24, "num_return_sequences": 1, "output_attentions": false, "output_hidden_states": false, "output_scores": false, "pad_token_id": null, "patch_size": 14, "prefix": null, "problem_type": null, "pruned_heads": {}, "remove_invalid_values": false, "repetition_penalty": 1.0, "return_dict": true, "return_dict_in_generate": false, "sep_token_id": null, "task_specific_params": null, "temperature": 1.0, "tf_legacy_loss": false, "tie_encoder_decoder": false, "tie_word_embeddings": true, "tokenizer_class": null, "top_k": 50, "top_p": 1.0, "torch_dtype": null, "torchscript": false, "transformers_version": "4.22.0.dev0", "typical_p": 1.0, "use_bfloat16": false }, "vision_config_dict": { "hidden_size": 1024, "intermediate_size": 4096, "num_attention_heads": 16, "num_hidden_layers": 24, "patch_size": 14 }

I did not test saving yet, will do now.

Saving works after #565 was applied.

pcuenca · 2022-09-19T09:04:10Z

src/diffusers/pipelines/stable_diffusion/safety_checker_flax.py

+        cos_dist = jax_cosine_distance(image_embeds, self.concept_embeds)
+        return special_cos_dist, cos_dist
+
+    def filtered_with_scores(self, special_cos_dist, cos_dist, images):


This method is not meant to be used with pmap, but it's fast as it just checks the scores.

src/diffusers/pipelines/stable_diffusion/safety_checker_flax.py

patrickvonplaten

If saving & loading works correctly good to go for me!

patil-suraj

LGTM, thanks for adding this!

src/diffusers/pipelines/stable_diffusion/safety_checker_flax.py

Co-authored-by: Suraj Patil <surajp815@gmail.com>

jonatanklosko · 2022-10-25T10:26:43Z

src/diffusers/pipelines/stable_diffusion/safety_checker_flax.py

+                result_img["special_scores"][concept_idx] = round(concept_cos - concept_threshold + adjustment, 3)
+                if result_img["special_scores"][concept_idx] > 0:
+                    result_img["special_care"].append({concept_idx, result_img["special_scores"][concept_idx]})
+                    adjustment = 0.01


Hey! Is there any reason to increase adjustment on the first "special care" concept, rather than after the loop, before we check "bad" concepts? Intuitively I understand that we use "special care" concepts to make the "bad" concepts check more strict, but I feel like "special care" should be orthogonal to other "special care" detection.

In the current version it doesn't really matter if there's one or more special care concepts, so I think either approach would be the same, but I'm curious if there's a specific reason behind this.

This is relevant because the conditional adjustment = 0.01 introduces a dependency between loop iterations. The alternative approach would be to move this outside the loop as: "if any special care score > 0 then set adjustment = 0.01 for bad concepts". With this, I think both loops could be vectorized (and in flax version they could probably be a part of __call__).

cc @patrickvonplaten

That's a good point - we can/should definitely move it out of the loop :-)

If you want feel free to open a PR for it :-)

Really good point @jonatanklosko

Perfect, thanks! I will submit a PR sometime this week :)

awesome, thanks a lot!

* Starting to integrate safety checker. * Fix initialization of CLIPVisionConfig * Remove commented lines. * make style * Remove unused import * Pass dtype to modules Co-authored-by: Suraj Patil <surajp815@gmail.com> * Pass dtype to modules Co-authored-by: Suraj Patil <surajp815@gmail.com> Co-authored-by: Suraj Patil <surajp815@gmail.com>

Starting to integrate safety checker.

1201501

pcuenca marked this pull request as draft September 19, 2022 07:29

pcuenca added 3 commits September 19, 2022 10:17

Fix initialization of CLIPVisionConfig

a3fb07f

Remove commented lines.

612b0c0

make style

c8d2cb9

pcuenca requested review from mishig25, patil-suraj and patrickvonplaten September 19, 2022 08:57

pcuenca commented Sep 19, 2022

View reviewed changes

Remove unused import

804e98a

pcuenca marked this pull request as ready for review September 19, 2022 09:08

patrickvonplaten reviewed Sep 19, 2022

View reviewed changes

src/diffusers/pipelines/stable_diffusion/safety_checker_flax.py Show resolved Hide resolved

patrickvonplaten approved these changes Sep 19, 2022

View reviewed changes

patil-suraj approved these changes Sep 19, 2022

View reviewed changes

src/diffusers/pipelines/stable_diffusion/safety_checker_flax.py Show resolved Hide resolved

src/diffusers/pipelines/stable_diffusion/safety_checker_flax.py Outdated Show resolved Hide resolved

src/diffusers/pipelines/stable_diffusion/safety_checker_flax.py Outdated Show resolved Hide resolved

pcuenca and others added 2 commits September 19, 2022 15:24

Pass dtype to modules

882542c

Co-authored-by: Suraj Patil <surajp815@gmail.com>

Pass dtype to modules

9706814

Co-authored-by: Suraj Patil <surajp815@gmail.com>

pcuenca merged commit fde9abc into main Sep 19, 2022

pcuenca deleted the jax-safety-checker branch September 19, 2022 13:26

jonatanklosko reviewed Oct 25, 2022

View reviewed changes

This was referenced Oct 27, 2022

Add safety checker for Stable Diffusion elixir-nx/bumblebee#82

Merged

Move safety detection to model call in Flax safety checker #1023

Merged

Conversation

pcuenca commented Sep 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

HuggingFaceDocBuilderDev commented Sep 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

patrickvonplaten left a comment

Choose a reason for hiding this comment

Uh oh!

patil-suraj left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

patrickvonplaten Oct 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

pcuenca commented Sep 19, 2022 •

edited

Loading

HuggingFaceDocBuilderDev commented Sep 19, 2022 •

edited

Loading

patrickvonplaten Oct 26, 2022 •

edited

Loading