Stabilise LMS and further stabilise DPM++ to eliminate residual noise in the result#5690
Closed
nhnt11 wants to merge 7 commits intohuggingface:mainfrom
Closed
Stabilise LMS and further stabilise DPM++ to eliminate residual noise in the result#5690nhnt11 wants to merge 7 commits intohuggingface:mainfrom
nhnt11 wants to merge 7 commits intohuggingface:mainfrom
Conversation
Author
|
I am still working on cleaning this up a bit and updating documentation for the LMS config param 🙏 |
Contributor
|
@yiyixuxu could you take a look here? |
…n-pipeline Impl denoising_start/end for SDXL ControlNet pipeline
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
Contributor
|
Gentle ping here @yiyixuxu |
Collaborator
|
hi sorry I didn't have time to look into this sooner. We got a couple more bug reports on DPM scheduler with I'm working on fixing it with PR here #6477 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR makes two changes:
order=1for the last 15 steps. This makes LMS usable with Image to Image with strength closer to 0 (e.g. 0.1). This solves LMS scheduler leaves a lot of noise leftover in the result image when used with SDXL Img2Img Pipeline #5630 (more example results in that issue's thread)0.0ifeuler_at_finalis true. This prevents residual noise in the result image. This solves DPM++ leaves residual noise in SDXL images, which is unexpected #5689 (more example results in that issue's thread)Fixes #5630, #5689