Update colab notebook to be under DDPM#628
Closed
tmabraham wants to merge 1 commit intohuggingface:mainfrom
Closed
Update colab notebook to be under DDPM#628tmabraham wants to merge 1 commit intohuggingface:mainfrom
tmabraham wants to merge 1 commit intohuggingface:mainfrom
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
Member
|
Hi @tmabraham! You are right, the notebook uses DDPM and not DDIM. In addition, I believe it's not in the right section at all, as it is a training notebook and not an example of how to use the pipeline as the others in the same table. I think I'd just remove it from that table and leave it in the training page that already links to it. Any other suggestions @patrickvonplaten @anton-l ? |
Contributor
Author
|
@pcuenca I can close this PR and make another one just removing it from that page... does that work? |
Member
|
Cool, that's fine by me :) |
Contributor
|
Agree that we should remove it @tmabraham would you like to update your PR? |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The link in the docs suggest that the training example is for DDIM when in fact it is for DDPM.