Skip to content

Fix SVD bug (shape of time_context)#7268

Merged
DN6 merged 5 commits intohuggingface:mainfrom
KimbingNg:main
Apr 1, 2024
Merged

Fix SVD bug (shape of time_context)#7268
DN6 merged 5 commits intohuggingface:mainfrom
KimbingNg:main

Conversation

@KimbingNg
Copy link
Copy Markdown
Contributor

@KimbingNg KimbingNg commented Mar 10, 2024

What does this PR do?

Fixes issue

The data arrangements in this line and this line are inconsistent, which could cause data mismatch during the cross-attention operation in this line when batch_size > 1.

Thus, it should be (b h w) n c instead of (h w b) n c.

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@sayakpaul sayakpaul requested a review from DN6 March 11, 2024 04:19
@sayakpaul
Copy link
Copy Markdown
Member

@DN6 a gentle ping here.

@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@DN6
Copy link
Copy Markdown
Collaborator

DN6 commented Mar 18, 2024

@KimbingNg Sorry, but I'm not quite sure what this is solving? The tensor shapes do match? Are you referring to the ordering of the elements inside the tensor?

@KimbingNg
Copy link
Copy Markdown
Contributor Author

@KimbingNg Sorry, but I'm not quite sure what this is solving? The tensor shapes do match? Are you referring to the ordering of the elements inside the tensor?

@DN6 Yes, I am referring to the ordering issue. The data arrangements in this line and this line are inconsistent, which could cause data mismatch during the cross-attention operation in this line when batch_size > 1

@DN6
Copy link
Copy Markdown
Collaborator

DN6 commented Mar 28, 2024

Ah I see. Looks okay to merge to me. cc @patil-suraj for visibility. Could you run make style && make quality so that the quality checks pass.

@KimbingNg
Copy link
Copy Markdown
Contributor Author

@DN6 I have run make style && make quality to format src/diffusers/models/transformers/transformer_temporal.py

@DN6 DN6 merged commit 9bef9f4 into huggingface:main Apr 1, 2024
noskill pushed a commit to noskill/diffusers that referenced this pull request Apr 5, 2024
* Fix SVD bug (shape of `time_context`)

* Formatting code

* Formatting src/diffusers/models/transformers/transformer_temporal.py by `make style && make quality`

---------

Co-authored-by: kevinkhwu <kevinkhwu@tencent.com>
Co-authored-by: Sayak Paul <spsayakpaul@gmail.com>
Co-authored-by: Dhruv Nair <dhruv.nair@gmail.com>
sayakpaul added a commit that referenced this pull request Dec 23, 2024
* Fix SVD bug (shape of `time_context`)

* Formatting code

* Formatting src/diffusers/models/transformers/transformer_temporal.py by `make style && make quality`

---------

Co-authored-by: kevinkhwu <kevinkhwu@tencent.com>
Co-authored-by: Sayak Paul <spsayakpaul@gmail.com>
Co-authored-by: Dhruv Nair <dhruv.nair@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants