Skip to content

Fix ONNX conversion script opset argument type#739

Merged
patrickvonplaten merged 1 commit intohuggingface:mainfrom
justinchuby:patch-1
Oct 7, 2022
Merged

Fix ONNX conversion script opset argument type#739
patrickvonplaten merged 1 commit intohuggingface:mainfrom
justinchuby:patch-1

Conversation

@justinchuby
Copy link
Copy Markdown
Contributor

The opset argument should be an int but was set as a str. This caused torch.onnx.export to fail when users specified a non-default opset version.

The opset argument should be an `int` but was set as a `str`.
@park66665
Copy link
Copy Markdown

I was about to make this PR too. It turns out you opened it 1 hour earlier. Anyways, hope this gets fixed sooner than later.

@patrickvonplaten
Copy link
Copy Markdown
Contributor

Thank you!

@patrickvonplaten patrickvonplaten merged commit 75bb6d2 into huggingface:main Oct 7, 2022
@justinchuby justinchuby deleted the patch-1 branch October 7, 2022 13:51
prathikr pushed a commit to prathikr/diffusers that referenced this pull request Oct 26, 2022
The opset argument should be an `int` but was set as a `str`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants