Skip to content

[Hunyuan] add optimization related sections to the hunyuan dit docs.#8402

Merged
sayakpaul merged 5 commits intomainfrom
hunyuan-opts-docs
Jun 6, 2024
Merged

[Hunyuan] add optimization related sections to the hunyuan dit docs.#8402
sayakpaul merged 5 commits intomainfrom
hunyuan-opts-docs

Conversation

@sayakpaul
Copy link
Copy Markdown
Member

What does this PR do?

As the name suggests.

@yiyixuxu and @gnobitab for awareness.

@sayakpaul sayakpaul requested a review from stevhliu June 5, 2024 06:03
@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Copy Markdown
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding!


Furthermore, you can use the `enable_forward_chunking()` method to reduce memory usage:

```diff
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
```diff
```py

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's actually diff in nature. Notice the "+" in the code.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, but I think it may be better to change it to python so users who copy/paste the code example don't get the "+" in it.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think our users will understand that difference given we make use of diff quite often throughout our docs.

sayakpaul and others added 4 commits June 6, 2024 01:26
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
@sayakpaul sayakpaul merged commit 867a2b0 into main Jun 6, 2024
@sayakpaul sayakpaul deleted the hunyuan-opts-docs branch June 6, 2024 00:11
sayakpaul added a commit that referenced this pull request Dec 23, 2024
…8402)

* optimizations to the hunyuan dit docs.

* Apply suggestions from code review

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>

* Update docs/source/en/api/pipelines/hunyuandit.md

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>

---------

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants