feat(host-rpc): add RpcAliasOracle with shared positive-result cache#114
Merged
feat(host-rpc): add RpcAliasOracle with shared positive-result cache#114
Conversation
c98993f to
42a76db
Compare
8e099db to
0b4117a
Compare
Member
Author
Code review[Claude Code] No issues found. Checked for bugs and CLAUDE.md compliance. Several items were considered but scored below threshold:
None of these rose to the level of a blocking issue. 🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
42a76db to
842b1f0
Compare
0d3de36 to
299e356
Compare
Fraser999
approved these changes
Mar 23, 2026
Merge RpcAliasOracle and RpcAliasOracleFactory into a single RpcAliasOracle type that implements both traits. Add a shared Arc<RwLock<HashSet>> cache for positive results — once an address is confirmed as a non-delegation contract, subsequent lookups return immediately without an RPC call. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Validate exact 23-byte length for EIP-7702 delegation detection - Add #[instrument] span on should_alias with debug events - Document std::sync::RwLock safety invariant (guards dropped before .await) - Extract should_alias_bytecode for testability, add 6 unit tests Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
299e356 to
fb78c75
Compare
auto-merge was automatically disabled
March 23, 2026 20:10
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Claude Code]
Summary
RpcAliasOracle<P>tosignet-host-rpc— an RPC-basedAliasOracle+AliasOracleFactorythat queries EIP-7702 delegation bytecode viaeth_getCodeArc<RwLock<HashSet<Address>>>cache across all clones/oracles: once an address is confirmed as a non-delegation contract, subsequent lookups skip the RPC callCloses ENG-2079.
PR stack
No remaining dependencies — this PR is ready to merge independently.
Test plan
cargo clippy -p signet-host-rpc --all-features --all-targets— cleancargo +nightly fmt --check— cleancargo t -p signet-host-rpc— pass🤖 Generated with Claude Code