Merged
Conversation
dan0505
approved these changes
Mar 16, 2026
7c43ccb to
4c5a575
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Public API endpoints were added to the intercom backend without updating the OpenAPI spec, making them invisible to customers.
GET /data_connectors/{id}was implemented inDataConnectorsControllerbut completely absent from all spec versions — customers using the list endpoint had no documented way to retrieve a single connector.How?
Added
GET /data_connectors/{id}to the Unstable spec, reusing the existingdata_connectorschema already defined for the list response. Unstable-only sinceGET /data_connectors(the list) is itself Unstable-only.Decisions
data_connectorsresource doesn't exist in v2.15, so backfilling the show endpoint there would be inconsistent.data_connectorobject schema was already defined by the list endpoint — no new schema needed.Implementation Plan
API Documentation Gap Plan
Context
Public API controllers in
API::V3have added features without updating OpenAPI specs. This causes customer pain — developers can't discover or use these endpoints. We'll use agent teams + git worktrees to close 4 gaps (feature-gated controllers skipped until rollout).Confirmed Gaps (this PR covers gap #1)
api/v3/data_connectors_controller.rbGET /data_connectors/{id}api/v3/fin_voice_controller.rbGET /fin_voice/conversation/{conversation_id}api/v3/conversation_parts_controller.rbPUT /conversations/{conversation_id}/conversation_parts/{id}api/v3/messages_controller.rbGET /messages/whatsapp/statusSkipped (feature-flagged, not yet GA)
fin/tasks_controller.rb—ai_answers_billing_featurefin/api_controller.rb—fin-agent-apiprocedures_controller.rb—ProcedureRuns::Constants::FEATURE_FLAGGenerated with Claude Code