Merged
Conversation
willscott
approved these changes
Feb 8, 2024
rvagg
approved these changes
Feb 9, 2024
Member
rvagg
left a comment
There was a problem hiding this comment.
approve in concept but something about the config needs to change, I think maybe it doesn't like empty users? @galargh probably either something for you to fix in the permissions checking code or something obvious to fix in the config here?
Contributor
Author
|
Thanks @rvagg ! I should have checked to make sure the checks pass first. We'll figure out how to get that passing and then merge. |
galargh
reviewed
May 6, 2024
Contributor
|
The following access changes will be introduced as a result of applying the plan: Access Changes |
Contributor
|
Before merge, verify that all the following plans are correct. They will be applied as-is after the merge. Terraform plansipld |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed some repos that should probably be archived.
Summary
The are some repos that no longer look to be used. They were identified while going through #65. I acted in #66, but want to apply this subset of changes to master and also remove permissions of the archived repos.
Why do you need this?
Not needed, but it's for declutter.
It's also not a one-way door. Repos can be unarchived if needed.
What else do we need to know?
None
DRI: myself
Reviewer's Checklist