[VC-43403] Revert to using sha256 checksum to match latest snapshot-links API#689
Merged
SgtCoDFish merged 1 commit intomasterfrom Aug 19, 2025
Merged
Conversation
Signed-off-by: Richard Wall <richard.wall@venafi.com>
34f71be to
ae38261
Compare
wallrj-cyberark
commented
Aug 19, 2025
SgtCoDFish
approved these changes
Aug 19, 2025
Contributor
SgtCoDFish
left a comment
There was a problem hiding this comment.
/lgtm
/approve
I haven't reviewed this forensically but it looks right, happy to review followups tomorrow!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The API team discovered that sha3 is not supported by the AWS backend, so have reverted to sha256.
I have also added the
x-amz-checksum-sha256request header. It causes AWS S3 to verify that it has received the expected payload.Ideally, that header would be required and be among the signed headers of the presigned URL, but the backend does not currently support that. See:
Testing
Before:
After: