Get --add-source working for dirs in Gradle builds#2156
Merged
inclement merged 3 commits intokivy:developfrom Apr 29, 2020
Merged
Get --add-source working for dirs in Gradle builds#2156inclement merged 3 commits intokivy:developfrom
inclement merged 3 commits intokivy:developfrom
Conversation
Member
|
I've previously tried this and had the same problems with getting patterns working, although I never tried the case without them so it's great to see that works. Would you mind adding a warning during the templating, notifying the user that their pattern will be ignored (if they passed one)? But other than that, I'm very happy to merge. |
Contributor
Author
|
Good call, thanks! Just added a warning, would this work? |
Member
|
@kollivier Looks good, fixed a couple of typos, will merge when the tests pass. |
inclement
approved these changes
Apr 29, 2020
Member
|
Thanks again! |
brvier
pushed a commit
to brvier/python-for-android
that referenced
this pull request
May 6, 2020
* Switch to using Gradle srcDir props for extra source dirs. * Add warning about only supporting source dir includes with gradle. * Fixed typos in gradle source directory warning Co-authored-by: Alexander Taylor <alexanderjohntaylor@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had trouble making the file patterns work using
include(no errors, but files didn't get included). However, this approach works for specifying source directories, which was our use case. Figured I'd post what we have now and see if anyone knows how to fix the patterns case, or knows if that case is used often?