build(deps): bump undici from 6.24.1 to 7.24.5 and drop Node.js 18#2815
build(deps): bump undici from 6.24.1 to 7.24.5 and drop Node.js 18#2815k8s-ci-robot merged 3 commits intomainfrom
Conversation
Bumps [undici](https://github.com/nodejs/undici) from 6.24.1 to 7.24.5. - [Release notes](https://github.com/nodejs/undici/releases) - [Commits](nodejs/undici@v6.24.1...v7.24.5) --- updated-dependencies: - dependency-name: undici dependency-version: 7.24.5 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
|
@copilot is there a way to fix this for Node 18 while still moving to undici 7 |
Yes! Added a polyfill in The polyfill is imported as the very first |
We could also consider dropping support for Node 18. It has been EOL since April 30, 2025. |
|
I'm in favor of dropping support for EOL versions. |
|
/lgtm I will remove node 18 from CI/CD in a different PR |
|
@copilot please remove node 18 from the CI/CD test matrix. |
|
Nevermind about a separate PR, there are more problems w/ Node 18 so we'll just remove it here. |
Agent-Logs-Url: https://github.com/kubernetes-client/javascript/sessions/d216a27f-d29a-431c-8a39-045d458bc9db Co-authored-by: brendandburns <5751682+brendandburns@users.noreply.github.com>
Done — removed Node.js 18 from the test matrix in commit |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, dependabot[bot] The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Bumps undici from 6.24.1 to 7.24.5.
undici v7 requires the
Fileglobal class, which is only available as a global in Node.js 20+. A polyfill (src/polyfill.ts) is included that setsglobalThis.Filefrom the built-innode:buffermodule when the global is not already defined, imported as the first side-effect import insrc/index.tsto ensure it runs before undici loads.Node.js 18 has been EOL since April 30, 2025 and has been removed from the CI test matrix (
.github/workflows/test.yml). The minimum supported Node.js version is now 20.Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.