feat: implement OpenRAG image management and cleanup functionality by ricofurtado · Pull Request #1056 · langflow-ai/openrag

ricofurtado · 2026-03-02T20:38:00Z

Bug Description

When experimenting with the first setup, I tried to factory reset my OpenRAG from TUI. To my surprise, all other dockers were gone from Docker desktop app, not only those OpenRAGs, but ALL OF THEM. This is certainly not something one would expect

Solution

This pull request refines how OpenRAG-related Docker/Podman images are identified and removed throughout the codebase, making image cleanup safer and more targeted. It introduces a centralized list of OpenRAG image repositories, implements dedicated logic for removing only relevant images (instead of pruning all system images), and updates both the Makefile and Python utilities/TUI to use this logic. This reduces the risk of accidentally deleting unrelated images and improves maintainability.

Centralized OpenRAG image repository management:

Added a single source of truth for OpenRAG image repositories as OPENRAG_IMAGE_REPOS in both the Makefile and Python modules, ensuring consistent identification of relevant images across all tooling.

Makefile improvements:

Introduced a new remove-openrag-images Makefile target that removes only OpenRAG images, and updated the clean and factory-reset targets to use this safer cleanup method instead of running a full system prune.

Python utility enhancements:

Added functions in startup_checks.py for extracting repositories, checking if an image is OpenRAG-related, and removing only OpenRAG images, replacing the previous broad docker system prune approach.

TUI (Terminal UI) container management updates:

Refactored the TUI's ContainerManager to use the new OpenRAG image identification logic for image listing, removal, and pruning, ensuring only relevant images are affected and removing duplicated logic.

User experience and messaging:

Updated user prompts and status messages throughout the CLI/TUI and Makefile to clearly indicate when only OpenRAG images are being removed, reducing confusion and risk.

Copilot

Pull request overview

Refines Docker/Podman cleanup behavior so “reset/cleanup” operations remove only OpenRAG-related images (instead of pruning the entire container runtime), reducing the risk of deleting unrelated images.

Changes:

Add OpenRAG image repository allow-lists and helper logic to identify/remove only matching images.
Update TUI container management reset/prune flows to use OpenRAG-only image listing/removal (no system prune).
Add unit tests covering OpenRAG-only image filtering and ensuring Docker “storage corruption” fixes don’t call system prune.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
tests/unit/test_startup_checks_cleanup.py	Adds tests for OpenRAG-only image removal and avoiding Docker `system prune`.
tests/unit/test_container_manager_cleanup.py	Adds tests for ContainerManager OpenRAG-only image listing and reset behavior.
src/tui/utils/startup_checks.py	Introduces OpenRAG repo allow-list + Docker-safe cleanup path for storage corruption handling.
src/tui/managers/container_manager.py	Adds OpenRAG image discovery helper and updates reset/prune routines to avoid global pruning.
Makefile	Adds `remove-openrag-images` target and routes `clean`/`factory-reset` through OpenRAG-only image removal.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/tui/utils/startup_checks.py

Copilot · 2026-03-02T21:41:43Z

src/tui/managers/container_manager.py

+        removed = 0
+        for image_id, image_tag in image_ids:
+            success, _, stderr = await self._run_runtime_command(["rmi", image_id])
+            if success:
+                removed += 1
+            else:
+                yield False, f"Could not remove {image_tag}: {stderr.strip()}"

        yield (
            True,
-            "System reset completed - all containers, volumes, and local images removed",
+            f"System reset completed - removed {removed} OpenRAG image(s)",
        )


reset_services() yields error updates when an image removal fails, but it still yields a final (True, ...) success message unconditionally. Track whether any removals failed and make the final status reflect partial/total failure (or return early on the first failure).

Copilot · 2026-03-02T21:41:43Z

src/tui/managers/container_manager.py

        """Prune old OpenRAG images and dependencies, keeping only the latest versions.

        This method:
        1. Lists all images
        2. Identifies OpenRAG-related images (openrag-backend, openrag-frontend, langflow, opensearch, dashboards)
        3. For each repository, keeps only the latest/currently used image
        4. Removes old images


The docstring says this method "Lists all images", but the implementation now calls _list_openrag_images(...) which filters to OpenRAG-related repositories only. Update the numbered steps so the documentation matches the behavior.

Copilot · 2026-03-02T21:41:43Z

Makefile

+remove-openrag-images: ## Remove OpenRAG images only (safe for other projects)
+	@echo "$(YELLOW)Removing OpenRAG images only...$(NC)"
+	@removed=0; total=0; \
+	for repo in $(OPENRAG_IMAGE_REPOS); do \
+		ids=$$($(CONTAINER_RUNTIME) images "$$repo" -q 2>/dev/null | sort -u); \
+		for id in $$ids; do \
+			total=$$((total+1)); \


remove-openrag-images only queries docker images "$$repo", so it may miss images tagged with an explicit registry prefix (e.g. docker.io/langflowai/openrag-frontend) even though the Python cleanup logic handles that case. Consider expanding the repo patterns (or using a single images --format scan like the Python implementation) so Makefile cleanup is consistent.

Considering...

Makefile

Copilot · 2026-03-02T21:41:44Z

tests/unit/test_startup_checks_cleanup.py

+from unittest.mock import MagicMock, patch
+
+from src.tui.utils import startup_checks
+


The unit tests import/patch src.tui..., but src/ is not a Python package in this repo (no src/__init__.py). Existing tests import from tui..., so these imports will fail during test collection. Update the import and patch targets to use the installed package path (e.g., tui.utils.startup_checks).

tests/unit/test_container_manager_cleanup.py

Copilot · 2026-03-02T21:41:44Z

src/tui/utils/startup_checks.py

+    result = subprocess.run(
+        [runtime, "images", "--format", "{{.Repository}}:{{.Tag}}\t{{.ID}}"],
+        capture_output=True,
+        text=True,
+    )
+    if result.returncode != 0:
+        return 0, 0
+


remove_openrag_images() returns (0, 0) when docker/podman images fails, which is indistinguishable from “no OpenRAG images found”. That makes callers treat failures as success. Consider returning a success flag / error message (or raising) so failures can be surfaced and handled.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

mpawlow

@ricofurtado

Code Review 1

✅ LGTM / Approved
See PR comment: (1a)
- Minor severity issue

mpawlow · 2026-03-09T16:40:12Z

src/tui/managers/container_manager.py

-        else:
-            yield False, f"Failed to prune dangling images: {stderr}"
-
        yield True, "All OpenRAG images removed successfully"


(1a) [Minor] prune_all_images emits a misleading "All OpenRAG images removed successfully" message even when no images were found

i.e. The if not images_to_remove branch yields "No OpenRAG images found to remove" but lacks a return, so execution always falls through to the unconditional final yield.

Note: This is Minor severity. Please feel free to optionally implement or ignore

feat: implement OpenRAG image management and cleanup functionality

d95869c

github-actions bot added backend 🔷 Issues related to backend services (OpenSearch, Langflow, APIs) tests enhancement 🔵 New feature or request labels Mar 2, 2026

ricofurtado self-assigned this Mar 2, 2026

ricofurtado requested review from Copilot and mpawlow March 2, 2026 21:35

github-actions bot added enhancement 🔵 New feature or request and removed enhancement 🔵 New feature or request labels Mar 2, 2026

Copilot started reviewing on behalf of ricofurtado March 2, 2026 21:36 View session

ricofurtado requested a review from lucaseduoli March 2, 2026 21:37

Copilot AI reviewed Mar 2, 2026

View reviewed changes

Update src/tui/utils/startup_checks.py

4b884ff

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

github-actions bot added enhancement 🔵 New feature or request and removed enhancement 🔵 New feature or request labels Mar 5, 2026

Update tests/unit/test_container_manager_cleanup.py

35f15c6

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

github-actions bot added enhancement 🔵 New feature or request and removed enhancement 🔵 New feature or request labels Mar 5, 2026

Update Makefile

f844a85

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

github-actions bot added enhancement 🔵 New feature or request and removed enhancement 🔵 New feature or request labels Mar 5, 2026

mpawlow approved these changes Mar 9, 2026

View reviewed changes

github-actions bot added the lgtm label Mar 9, 2026

ricofurtado merged commit 2d506e9 into main Mar 9, 2026
11 checks passed

github-actions bot deleted the 1015-factory-reset-deletes-other-docker-images branch March 9, 2026 17:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: implement OpenRAG image management and cleanup functionality#1056

feat: implement OpenRAG image management and cleanup functionality#1056
ricofurtado merged 4 commits intomainfrom
1015-factory-reset-deletes-other-docker-images

ricofurtado commented Mar 2, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI Mar 2, 2026

Uh oh!

Copilot AI Mar 2, 2026

Uh oh!

Copilot AI Mar 2, 2026

Uh oh!

ricofurtado Mar 6, 2026

Uh oh!

Uh oh!

Copilot AI Mar 2, 2026

Uh oh!

Uh oh!

Copilot AI Mar 2, 2026

Uh oh!

mpawlow left a comment

Uh oh!

mpawlow Mar 9, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		from unittest.mock import MagicMock, patch

		from src.tui.utils import startup_checks

Conversation

ricofurtado commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bug Description

Solution

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

ricofurtado Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

mpawlow left a comment

Choose a reason for hiding this comment

Code Review 1

Uh oh!

mpawlow Mar 9, 2026

Choose a reason for hiding this comment

(1a) [Minor] prune_all_images emits a misleading "All OpenRAG images removed successfully" message even when no images were found

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ricofurtado commented Mar 2, 2026 •

edited

Loading

(1a) [Minor] `prune_all_images` emits a misleading "All OpenRAG images removed successfully" message even when no images were found