feat: Introduce ManagedModel and ModelRunner (PR-3)#104
Open
jsonbailey wants to merge 6 commits intomainfrom
Open
feat: Introduce ManagedModel and ModelRunner (PR-3)#104jsonbailey wants to merge 6 commits intomainfrom
jsonbailey wants to merge 6 commits intomainfrom
Conversation
jsonbailey
changed the title
jsonbailey
force-pushed
the
jb/aic-1664/managed-model
branch
from
39bac26 to
3fc5d47
Compare
jsonbailey
force-pushed
the
jb/aic-1664/adapter-executor-factory
branch
from
4bef65c to
e10be52
Compare
feat: Add ModelRunner ABC with invoke_model() and invoke_structured_model() feat: Add ManagedModel replacing Chat; expose get_model_runner() escape hatch feat!: Rename ChatResponse to ModelResponse in providers/types.py feat!: Extract OpenAIModelRunner from OpenAIRunnerFactory; factory is now model-creation-only feat!: Extract LangChainModelRunner from LangChainRunnerFactory; factory is now model-creation-only feat: Add OpenAIHelper with shared utilities for model and future agent runners feat: Add LangChainHelper with shared utilities for model and future agent runners feat!: LangChainRunnerFactory is now a no-arg factory; static helpers moved to LangChainHelper fix: LDClient.create_chat() is deprecated in favour of create_model() fix: Chat alias in ldai.chat is deprecated in favour of ManagedModel fix: Rename ai_provider param to model_runner in Judge and ManagedModel
jsonbailey
force-pushed
the
jb/aic-1664/managed-model
branch
from
3fc5d47 to
fc3880c
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
packages/ai-providers/server-ai-langchain/src/ldai_langchain/langchain_model_runner.py
Outdated
Show resolved
Hide resolved
packages/ai-providers/server-ai-langchain/src/ldai_langchain/langchain_helper.py
Outdated
Show resolved
Hide resolved
packages/ai-providers/server-ai-langchain/src/ldai_langchain/langchain_helper.py
Show resolved
Hide resolved
jsonbailey
changed the title
…heck, and Bedrock provider param
packages/ai-providers/server-ai-openai/src/ldai_openai/openai_runner_factory.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
packages/ai-providers/server-ai-openai/src/ldai_openai/openai_model_runner.py
Outdated
Show resolved
Hide resolved
…ve unused import - Restore mutable structured_response pattern from f951dac so raw_response and usage are preserved even when an exception occurs after partial extraction - Rename LangChainHelper.convert_messages -> convert_messages_to_langchain - Rename OpenAIHelper.convert_messages -> convert_messages_to_openai - Remove unused TokenUsage import from openai_model_runner.py - Fix runner_factory.create_model return type to Optional[ModelRunner] - Fix isort in langchain/openai runner and helper files - Fix isort in ldai/__init__.py and client.py Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: Add ModelRunner ABC with invoke_model() and invoke_structured_model()
feat: Add ManagedModel replacing Chat; expose get_model_runner() escape hatch
feat!: Rename ChatResponse to ModelResponse in providers/types.py
feat!: Extract OpenAIModelRunner from OpenAIRunnerFactory; factory is now model-creation-only
feat!: Extract LangChainModelRunner from LangChainRunnerFactory; factory is now model-creation-only
feat: Add OpenAIHelper with shared utilities for model and future agent runners
feat: Add LangChainHelper with shared utilities for model and future agent runners
feat: Add create_model(); deprecate create_chat()
Note
High Risk
High risk because it introduces breaking API changes (
ChatResponse→ModelResponse,create_chat→create_model, provider factories now returnModelRunners) and rewires judge/model invocation plumbing, which could break downstream integrations despite added shims.Overview
Introduces a new runtime abstraction for model execution. Adds
ModelRunnerandManagedModel, shifting conversation management and metrics tracking intoManagedModelwhile providers now return configured runner instances.API surface is refactored (with breaking changes + shims).
ChatResponseis renamed toModelResponse,LDAIClient.create_model()is added andcreate_chat()is deprecated (andldai.chat.Chatbecomes a deprecated alias ofManagedModel).Judgenow depends on aModelRunnerinstead of anAIProvider.Provider packages are reorganized around runners and helpers. OpenAI and LangChain split invocation logic into
*ModelRunnerclasses and extract shared utilities into*Helper; their*RunnerFactoryclasses are reduced to model construction only, with tests updated accordingly.Written by Cursor Bugbot for commit c2f7475. This will update automatically on new commits. Configure here.