Connect peers on startup in tests#1024
Merged
TheBlueMatt merged 1 commit intolightningdevkit:mainfrom Jul 30, 2021
Merged
Conversation
This avoids `ChannelManager` ever being confused by the fact that it received a message from a peer which it didn't think it was connected to.
TheBlueMatt
force-pushed
the
2021-07-always-connect-in-tests
branch
from
bcbd4f1 to
2745bd5
Compare
Contributor
|
ACK 2745bd5 Thanks for the quick fix! |
jkczyz
approved these changes
Jul 30, 2021
Contributor
jkczyz
left a comment
jkczyz
left a comment
There was a problem hiding this comment.
Not sure if the ubuntu beta failures are related, but I tested on macos locally without a problem.
Codecov Report
@@ Coverage Diff @@
## main #1024 +/- ##
=======================================
Coverage 90.82% 90.82%
=======================================
Files 60 60
Lines 31455 31462 +7
=======================================
+ Hits 28568 28575 +7
Misses 2887 2887
Continue to review full report at Codecov.
|
valentinewallace
approved these changes
Jul 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids
ChannelManagerever being confused by the fact thatit received a message from a peer which it didn't think it was
connected to.
This supersedes #971 cc @jkczyz