Export and document all log macros.#1682
Merged
TheBlueMatt merged 1 commit intolightningdevkit:mainfrom Aug 24, 2022
Merged
Conversation
Previously, only `log_error` and `log_trace` macros have been exported. This change exports the macros of all log levels, which enables them to be used downstream.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1682 +/- ##
==========================================
+ Coverage 90.76% 90.86% +0.09%
==========================================
Files 87 85 -2
Lines 47595 45714 -1881
Branches 47595 45714 -1881
==========================================
- Hits 43198 41536 -1662
+ Misses 4397 4178 -219 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
valentinewallace
approved these changes
Aug 24, 2022
TheBlueMatt
approved these changes
Aug 24, 2022
This was referenced Sep 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, only
log_errorandlog_tracemacros have been exported.This change exports the macros of all log levels, which enables them to be used downstream.