BOLT 12 offer encoding and building#1719
Merged
TheBlueMatt merged 6 commits intolightningdevkit:mainfrom Nov 8, 2022
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Define an interface for BOLT 12
offermessages. The underlying format consists of the original bytes and the parsed contents.The bytes are later needed when constructing an
invoice_requestmessage. This is because it must mirror all theofferTLV records, including unknown ones, which aren't represented in the contents.The contents will be used in
invoice_requestmessages to avoid duplication. Some fields while required in a typical user-pays-merchant flow may not be necessary in the merchant-pays-user flow (i.e., refund).Also, defines a builder for constructing an offer given a required description and node id.
See #1597 for ongoing BOLT 12 work depending on this PR.