Make test_esplora_syncs more robust#2033
Merged
TheBlueMatt merged 1 commit intolightningdevkit:mainfrom Feb 27, 2023
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2032.
The test generally works fine and the calls in question should never fail. However, they did break eventually in CI.
I'm guessing that in the case of #2032 the
electrsdfor some reason hadn't finished launching yet when we tried to to access its interface. Therefore this PR adds some changes that should give thebitcoind/electrsdserver instances some more time to fully get setup and generally some more leeway.