changed keysinterface.rs to signer.rs#2159
changed keysinterface.rs to signer.rs#2159TomNag-CS50 wants to merge 1 commit intolightningdevkit:mainfrom
Conversation
TheBlueMatt
left a comment
TheBlueMatt
left a comment
There was a problem hiding this comment.
Dunno if signer is right given it also includes EntropySource, but I think its better than keysinterface. Maybe let's do something like "crypto"? Dunno if that's too generic.
While you're at it can you move it out of the chain module and into the top-level lightning crate/lib?
| @@ -1 +1 @@ | |||
| ../../lightning/src/util/time.rs No newline at end of file | |||
| ../../lightning/src/util/time.rs | |||
There was a problem hiding this comment.
Looks like you made this no longer a symlink, which broke build?
There was a problem hiding this comment.
ill check again, but running it on main branch unchanged produced the same error.
There was a problem hiding this comment.
I think your git/OS/filesystem bungled the symlink and somehow replaced it with a file, which is why it failed locally and failed once checked in.
How about a |
| /// | ||
| /// This allows us to generate a [`Balance::CounterpartyRevokedOutputClaimable`] for the | ||
| /// This allows us to generate a [`Balance::CounterpartyRevokedOutputClaimable`] for | ||
| /// thechaannmo |
There was a problem hiding this comment.
typo: /// thechaannmo, also should use spaces not tabs (though the full line will be deleted so it doesn't matter much here).
Ugh, we have separate parallel threads: #2157 (comment) |
Seems like progress has stall here and you may do this as part of some other work @arik-so? |
|
@TomNag-CS50 any interest in redoing this with the suggestions in the thread at #2157? |
|
Superseded by #2246. More splitting of the sign module would be welcome in a followup PR, if you find the time, @TomNag-CS50. |
5 participants
changed keysinterface.rs to to signer.rs