f - Provide channel_monitor with first per_commitment_point of channel#228
Closed
ariard wants to merge 1 commit intolightningdevkit:masterfrom
Closed
f - Provide channel_monitor with first per_commitment_point of channel#228ariard wants to merge 1 commit intolightningdevkit:masterfrom
ariard wants to merge 1 commit intolightningdevkit:masterfrom
Conversation
Collaborator
|
This looks like a fix against 2d8afec, which was April of this year, so should just go in as a normal PR with a test? I don't think this is blocking the 0.0.6 demo? |
Collaborator
|
Also kinda related: #195. Apparently we just don't handle the first commitment txn well in channel monitoring. |
Author
|
Yes, working on a normal PR for this one, and also covering #195 (even if it's loosely related) |
Author
|
See #230, will close it when I open PR for better way to provide per_commitment_point and keys interface tests. |
Author
|
New commits in #230 should do the job I think |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.