Fix multi-remote-HTLC-claim preimage learning#282
Merged
TheBlueMatt merged 1 commit intolightningdevkit:masterfrom Jan 9, 2019
Merged
Fix multi-remote-HTLC-claim preimage learning#282TheBlueMatt merged 1 commit intolightningdevkit:masterfrom
TheBlueMatt merged 1 commit intolightningdevkit:masterfrom
Conversation
This was referenced Jan 6, 2019
ariard
reviewed
Jan 9, 2019
ariard
approved these changes
Jan 9, 2019
ariard
left a comment
ariard
left a comment
There was a problem hiding this comment.
Thanks for correction, timeout tx on inbound HTLC may be also shared but we only log them, no upstream feedback.
When our counterparty claims multiple HTLCs from offered outputs in one transaction we should still be able to learn the preimages. Sadly, due to two bugs we were not previously doing so.
TheBlueMatt
force-pushed
the
2019-01-multi-htlc-claims
branch
from
76c37df to
c9df4bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When our counterparty claims multiple HTLCs from offered outputs in
one transaction we should still be able to learn the preimages.
Sadly, due to two bugs we were not previously doing so.